[Bug 1816135] Review Request: libjcat - Library for reading Jcat files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1816135

Kalev Lember <klember@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |klember@xxxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |klember@xxxxxxxxxx
              Flags|                            |fedora-review+



--- Comment #1 from Kalev Lember <klember@xxxxxxxxxx> ---
A few notes:

> %{_datadir}/vala/vapi/jcat.deps
> %{_datadir}/vala/vapi/jcat.vapi

You should make sure the directory is included in the package to not cause
unowned directories when uninstalling the rpm. Something like:

%dir %{_datadir}/vala
%dir %{_datadir}/vala/vapi

... should take care of it.


> %{_libexecdir}/installed-tests/libjcat/jcat-self-test
> %{_datadir}/installed-tests/libjcat/*
> %dir %{_datadir}/installed-tests/libjcat

Same thing here, need to own %{_datadir}/installed-tests and
%{_libexecdir}/installed-tests and %{_libexecdir}/installed-tests/libjcat
directories.


> %check
> %meson_test
> 
> %install
> %meson_install

This is not really a problem, but I'd personally reorder the two sections
because %check runs after %install.

> %{_datadir}/man/man1/*.1.gz

Can you use a glob such as '*.1*' to avoid hard coding the .gz extension?
Flatpak builds for instance use different compression.

rpmlint output:

$ rpmlint libjcat-0.1.0-0.23.20200323git.fc32.src.rpm
libjcat-0.1.0-0.23.20200323git.fc32.src.rpm
libjcat-devel-0.1.0-0.23.20200323git.fc32.x86_64.rpm
libjcat-tests-0.1.0-0.23.20200323git.fc32.x86_64.rpm
libjcat.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
libjcat.src: W: spelling-error %description -l en_US checksums -> check sums,
check-sums, checks
libjcat.src: W: file-size-mismatch libjcat-0.1.0.tar.xz = 52096,
http://people.freedesktop.org/~hughsient/releases/libjcat-0.1.0.tar.xz = 52148
libjcat.src: W: spelling-error %description -l en_US gzip -> zip, grip, g zip
libjcat.src: W: spelling-error %description -l en_US checksums -> check sums,
check-sums, checks
libjcat.src: W: file-size-mismatch libjcat-0.1.0.tar.xz = 52096,
http://people.freedesktop.org/~hughsient/releases/libjcat-0.1.0.tar.xz = 52148
4 packages and 0 specfiles checked; 0 errors, 6 warnings.

The file size being different sounds like either you updated the tarball or
there's a man in the middle attack :) Maybe update the tarball in the srpm and
switch to https sources to make MITM harder to do?

These are all just small nitpicks; package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux