https://bugzilla.redhat.com/show_bug.cgi?id=1814887 Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |POST Assignee|nobody@xxxxxxxxxxxxxxxxx |i.gnatenko.brain@xxxxxxxxx Flags| |fedora-review+ --- Comment #7 from Igor Gnatenko <i.gnatenko.brain@xxxxxxxxx> --- LGTM. Just a few notes: * You probably forgot to git push in upstream repo * pkg_config::find_library("slirp").unwrap(); suggests that any version will work, but in spec file you have >= 4.0.0, you probably want to either drop that part in spec or add some restriction in upstream. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
