[Bug 1815810] Review Request: python-pg8000 - Pure Python PostgreSQL Driver

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1815810



--- Comment #8 from Ernestas Kulik <ekulik@xxxxxxxxxx> ---
(In reply to Neal Gompa from comment #7)
> Initial review comments:
> 
> > BuildRequires:  python3-setuptools
> 
> I'd suggest using "python3dist(setuptools)" here.

Sure thing.

> > Suggests:       python3-sqlalchemy
> 
> I'd suggest using "Enhances: python3dist(sqlalchemy)" here. It's a reverse
> hint, not a forward one.

Will do.

> > Suggests:       postgresql
> 
> Why are you suggesting this? This doesn't use the PostgreSQL clients at
> all...

You have to realize that there is historical baggage and that someone already
approved the changes, so I’m not questioning everything I come in touch with.

I did, however, find https://bugzilla.redhat.com/show_bug.cgi?id=1304522#c8, so
seems that it can go.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux