[Bug 1811485] Review Request: non-daw - Digital Audio Workstation for Jack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1811485



--- Comment #14 from Erich Eickmeyer <erich@xxxxxxxxxxxxxxxxxx> ---
> > > License should be GPLv2+ and ISC (there is one file with ISC license)
> > 
> > Fixed.
> This should be exactly
> GPLv2+ and ISC

Actually fixed now.

> I think Requires: hicolor-icon-theme is missing from main package

Fixed.

> The only other minor issue I see know, after enabling verbose build are some compiler optimization that should be avoid in Fedora, like -O3, which get appended to Fedora build flags.

I went ahead and patched the wscript to remove the optimization flags since
Fedora has its own.

New files:
Spec URL:
https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01314609-non-daw/non-daw.spec
SRPM URL:
https://download.copr.fedorainfracloud.org/results/eeickmeyer/Jam-Incoming/fedora-rawhide-x86_64/01314609-non-daw/non-daw-1.2.0-19.20200307gitbbe8386.fc33.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux