https://bugzilla.redhat.com/show_bug.cgi?id=1811485 --- Comment #10 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- Versioning is not correct. Latest version in Fedora was 1.2.0-18... so you should increment by one and start with 1.2.0-19%{commitdate}git%{shortcommit0}%{?dist} You didn't use the latest spec when unretiring this package and cut some of the recent history, which could be useful. License should be GPLv2+ and ISC (there is one file with ISC license) Many source files have incorrect FSF address, this must be corrected by a patch, there is a sed script that can help do this. You can't modify COPYING file because only upstream can do that, but you should notify of the incorrect FSF address and maybe send a patch. License file (COPYING) must be added to every subpackage, because they can be installed separately. Output of fedora review related to comment #5, with some manual checks. Some cheks are still missing and there are cheks that do not pass. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/non-daw See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 2242560 bytes in 46 files. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_documentation ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* BSD 3-clause "New" or "Revised" License", "GPL (v2 or later) (with incorrect FSF address)", "ISC License". 154 files have unknown license. Detailed output of licensecheck in /home/guido/tmp/1811485-non-daw/licensecheck.txt [!]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/share/icons/hicolor/32x32, /usr/share/icons/hicolor, /usr/share/icons/hicolor/256x256, /usr/share/icons/hicolor/72x72/apps, /usr/share/icons/hicolor/64x64, /usr/share/icons/hicolor/128x128, /usr/share/icons/hicolor/256x256/apps, /usr/share/icons/hicolor/512x512/apps, /usr/share/icons/hicolor/36x36/apps, /usr/share/icons/hicolor/36x36, /usr/share/icons/hicolor/64x64/apps, /usr/share/icons/hicolor/48x48, /usr/share/icons/hicolor/192x192/apps, /usr/share/icons/hicolor/16x16, /usr/share/icons/hicolor/128x128/apps, /usr/share/icons/hicolor/48x48/apps, /usr/share/icons/hicolor/192x192, /usr/share/icons/hicolor/16x16/apps, /usr/share/icons/hicolor/72x72, /usr/share/icons/hicolor/96x96/apps, /usr/share/icons/hicolor/512x512, /usr/share/icons/hicolor/32x32/apps, /usr/share/icons/hicolor/96x96 [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in non- mixer , non-session-manager , non-sequencer [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 3430400 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: non-daw-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-mixer-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-session-manager-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-sequencer-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-daw-debuginfo-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-daw-debugsource-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm non-daw-1.2.0-1.20200307gitbbe8386.fc33.src.rpm non-daw.x86_64: W: incoherent-version-in-changelog 1.2.0-1.gitbbe83864 ['1.2.0-1.20200307gitbbe8386.fc33', '1.2.0-1.20200307gitbbe8386'] non-daw.x86_64: W: no-manual-page-for-binary import-ardour-session_gui non-daw.x86_64: W: no-manual-page-for-binary non-daw non-daw.x86_64: W: no-manual-page-for-binary non-timeline non-mixer.x86_64: W: no-manual-page-for-binary non-midi-mapper non-mixer.x86_64: W: no-manual-page-for-binary non-mixer non-mixer.x86_64: W: no-manual-page-for-binary non-mixer-noui non-session-manager.x86_64: W: no-manual-page-for-binary jackpatch non-session-manager.x86_64: W: no-manual-page-for-binary non-session-manager non-session-manager.x86_64: W: no-manual-page-for-binary nsm-proxy non-session-manager.x86_64: W: no-manual-page-for-binary nsm-proxy-gui non-session-manager.x86_64: W: no-manual-page-for-binary nsmd non-sequencer.x86_64: W: no-manual-page-for-binary non-sequencer non-daw.src: W: strange-permission non-snapshot.sh 775 7 packages and 0 specfiles checked; 0 errors, 14 warnings. Rpmlint (debuginfo) ------------------- Checking: non-daw-debuginfo-1.2.0-1.20200307gitbbe8386.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "it_IT.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "it_IT.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). non-mixer.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> non-mixer.x86_64: W: no-manual-page-for-binary non-midi-mapper non-mixer.x86_64: W: no-manual-page-for-binary non-mixer non-mixer.x86_64: W: no-manual-page-for-binary non-mixer-noui non-daw.x86_64: W: incoherent-version-in-changelog 1.2.0-1.gitbbe83864 ['1.2.0-1.20200307gitbbe8386.fc33', '1.2.0-1.20200307gitbbe8386'] non-daw.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> non-daw.x86_64: W: no-manual-page-for-binary import-ardour-session_gui non-daw.x86_64: W: no-manual-page-for-binary non-daw non-daw.x86_64: W: no-manual-page-for-binary non-timeline non-sequencer.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> non-sequencer.x86_64: W: no-manual-page-for-binary non-sequencer non-session-manager.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> non-session-manager.x86_64: W: no-manual-page-for-binary jackpatch non-session-manager.x86_64: W: no-manual-page-for-binary non-session-manager non-session-manager.x86_64: W: no-manual-page-for-binary nsm-proxy non-session-manager.x86_64: W: no-manual-page-for-binary nsm-proxy-gui non-session-manager.x86_64: W: no-manual-page-for-binary nsmd non-daw-debugsource.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> non-daw-debuginfo.x86_64: W: invalid-url URL: https://non.tuxfamily.org/ <urlopen error [Errno -2] Name or service not known> 6 packages and 0 specfiles checked; 0 errors, 19 warnings. Source checksums ---------------- https://git.tuxfamily.org/non/non.git/snapshot/non-bbe8386499621c8e60eebb06d80e966f13a69a95.tar.gz : CHECKSUM(SHA256) this package : 4ea2d5abd810d00b4fb99b5f79383c09bd9e59f36f356c9371100fd06bc30f8a CHECKSUM(SHA256) upstream package : 4ea2d5abd810d00b4fb99b5f79383c09bd9e59f36f356c9371100fd06bc30f8a Requires -------- non-daw (rpmlib, GLIBC filtered): jack-audio-connection-kit libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjack.so.0()(64bit) liblo.so.7()(64bit) libm.so.6()(64bit) libntk.so.1()(64bit) libntk_images.so.1()(64bit) libpthread.so.0()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) non-ntk non-ntk-fluid rtld(GNU_HASH) non-mixer (rpmlib, GLIBC filtered): jack-audio-connection-kit libc.so.6()(64bit) libcairo.so.2()(64bit) libdl.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjack.so.0()(64bit) liblo.so.7()(64bit) liblrdf.so.2()(64bit) libm.so.6()(64bit) libntk.so.1()(64bit) libntk_images.so.1()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) rtld(GNU_HASH) non-session-manager (rpmlib, GLIBC filtered): jack-audio-connection-kit libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjack.so.0()(64bit) liblo.so.7()(64bit) libntk.so.1()(64bit) libntk_images.so.1()(64bit) libpthread.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) non-sequencer (rpmlib, GLIBC filtered): jack-audio-connection-kit libX11.so.6()(64bit) libc.so.6()(64bit) libcairo.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libjack.so.0()(64bit) liblo.so.7()(64bit) libntk.so.1()(64bit) libntk_images.so.1()(64bit) libpthread.so.0()(64bit) libsigc-2.0.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) rtld(GNU_HASH) non-daw-debuginfo (rpmlib, GLIBC filtered): non-daw-debugsource (rpmlib, GLIBC filtered): Provides -------- non-daw: application() application(non-timeline.desktop) non-daw non-daw(x86-64) non-mixer: application() application(non-mixer.desktop) non-mixer non-mixer(x86-64) non-session-manager: application() application(non-session-manager.desktop) non-session-manager non-session-manager(x86-64) non-sequencer: application() application(non-sequencer.desktop) non-sequencer non-sequencer(x86-64) non-daw-debuginfo: debuginfo(build-id) non-daw-debuginfo non-daw-debuginfo(x86-64) non-daw-debugsource: non-daw-debugsource non-daw-debugsource(x86-64) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
