https://bugzilla.redhat.com/show_bug.cgi?id=1811485 Guido Aulisi <guido.aulisi@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|needinfo?(guido.aulisi@gmai | |l.com) | --- Comment #6 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- Sorry for the late answer, I'm posting some other findings, then I will post the review: > BuildRequires: fltk-devel > BuildRequires: fltk-fluid Are these really needed? In particular fltk-fluid shouldn't be needed, because it's a GUI to design widgets. > BuildRequires: non-ntk-fluid Same as above. > Requires: non-ntk > Requires: non-ntk-fluid These are not needed, because rpm finds dependencies automatically, and non-ntk-fluid isn't needed at runtime. You should add Buildrequires: %{_bindir}/find because you use it patching python shebangs. You are not running the build command, you should add as the latest command in %build section this: ./waf build -v %{?_smp_mflags} It runs build in verbose mode and with parallelism. I will post the output of fedora-review ASAP, I think the package is fine. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
