https://bugzilla.redhat.com/show_bug.cgi?id=1806386 --- Comment #4 from Mamoru TASAKA <mtasaka@xxxxxxxxxxxxxxxxx> --- Thank you for comments: - Why do you change the icon? And remove all icons? Using system-wide icon enables the looks to change according to system style. - Why don't you keep the desktop file in applications? Even if you autorun it, it should be accessible from the menu. Because this is not something like "GUI". This is usually aimed for staying on panels. - This shouldn't be marked as %config I think: - %config %{_sysconfdir}/xdg/autostart/%{name}.desktop I see some other packages actually mark these files (under /etc/xdg/autostart) as %config (but not (noreplace)), but I can rethink this later. - Split the doc into a noarch subpackage: I don't think I should split html files into another subpackage for this rpm for now. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
