https://bugzilla.redhat.com/show_bug.cgi?id=1814349 --- Comment #3 from Nicolas Mailhot <nicolas.mailhot@xxxxxxxxxxx> --- (In reply to Parag Nemade from comment #2) > Can you please help me to understand, what is wrong with this new SPEC file? > It is not constructing proper Source URL. > https://pnemade.fedorapeople.org/fedora-work/SPECS/ht-caladea-fonts.spec > > It appears many packages I reviewed that uses %forgeurl, also added commit > id but strange I missed to notice that they are not present for few other > packages like ht-alegreya-sans-fonts, uswds-public-sans-fonts, > jetbrains-mono-fonts, ibm-plex-fonts. Commit hash is used when upstream has not tagged a release with a tag that derives from version, in a common way (common not standard, because Linus sucks at versioning, and could not bother with a version reference in git with machine-readable structure) When tag exists, but does not follow conventions, you have to declare it explicitly (convention is v%{version} for github and %{version} for everyone else) When there is no tag to rely on you need an explicit commit ID https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/ > Also, upstream uses 1.001 version whereas existing package used 1.002 so I > think Epoch need to be added now. Well, it seems upstream lost some changes. Not surprising when you consider a VCS optional. You can point them to the archive you used before, in case they manage to salvage it. Else, it would be nice if they released 1.003 Otherwise, yes, Epoch applies, typical example of interrupted history with a versionning break in the middle -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
