https://bugzilla.redhat.com/show_bug.cgi?id=1815154 --- Comment #9 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- (In reply to José Matos from comment #8) > (In reply to Fabian Affolter from comment #6) > > (In reply to José Matos from comment #5) > > > (In reply to Fabian Affolter from comment #4) > > > > - Wrong URL, it's the other one ;-) > > > > > > > > URL: https://schettino72.github.io/sphinx_press_site/ > > > > Source0: %{pypi_source} > > > > > > Actually it is not possible because the source and pypi names are different: > > > > > > sphinx_press_theme <- source name > > > sphinx-press-theme <- pypi name > > > > %{pypi_source} can take multiple argument -> > > https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/ > > #_source_files_from_pypi > > > > Could work with %{pypi_source sphinx_press_theme} > > Thanks for the reminder, that is neat. > Yet when I did that change and rebuilt the rpm I got: > > $ rpmbuild -ba python-sphinx-press-theme.spec > error: line 2: Unknown tag: > https://files.pythonhosted.org/packages/source/s/sphinx_press_theme/ > sphinx_press_theme-%version.tar.gz > > The %version was not expanded. I am using Fedora 32. > > @Miro: was this to be expected? This is missing the Source tag, you need something like: Source0: %{pypi_source sphinx_press_theme} > > > > - The package must own the directories that are created. > > > > > > > > %{python3_sitelib}/sphinx_press_theme/ > > > > > > > > %{python3_sitelib}/sphinx_press_theme-%{version}-py%{python3_version}.egg- > > > > info/ > > > > > > But it is already there. By placing the directory name with the final slash > > > (/) it means the directory and all its files. > > > > See > > https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes > > I understand and share you concern regarding unowned directories but the > page above does not warn about the usage done in the spec. > > If I remember correctly (I can be wrong naturally) this line in %files > %{python3_sitelib}/sphinx_press_theme > > is equivalent to > %dir %{python3_sitelib}/sphinx_press_theme > %{python3_sitelib}/sphinx_press_theme/ > > I even tried to install and remove the corresponding rpm and the directories > are correctly removed when the package is uninstalled. The trailing slashes are optional. However I consider them better: It is clear that it is a directory (and the build fails if it is not a directory). However, even without the slashes, it contains the entire directory and the content in it. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
