Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: gnome-packagekit - gnome applications for PackageKit https://bugzilla.redhat.com/show_bug.cgi?id=333471 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Status|NEW |ASSIGNED Flag| |fedora-review? ------- Additional Comments From panemade@xxxxxxxxx 2007-10-16 06:28 EST ------- Preliminary review => 1)I will suggest to have this package named as gnome-PackageKit. 2) Use of make should be as given in http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e 3) defattr should be defattr(-,root,root,-) 4) Remove following line from SPEC from %files section %{_datadir}/gnome-packagekit/pk-*.glade 5)You should install all .desktop files as given in http://fedoraproject.org/wiki/Packaging/Guidelines#head-254ddf07aae20a23ced8cecc219d8f73926e9755 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review