[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1815154

Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|1815489                     |



--- Comment #6 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> ---
(In reply to José Matos from comment #5)
> (In reply to Fabian Affolter from comment #4)
> > - Wrong URL, it's the other one ;-)
> > 
> >   URL:            https://schettino72.github.io/sphinx_press_site/
> >   Source0:        %{pypi_source}
> 
> Actually it is not possible because the source and pypi names are different:
> 
> sphinx_press_theme <- source name
> sphinx-press-theme <- pypi name

%{pypi_source} can take multiple argument ->
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_source_files_from_pypi

Could work with  %{pypi_source sphinx_press_theme}

> > - The package must own the directories that are created.
> > 
> >   %{python3_sitelib}/sphinx_press_theme/
> >  
> > %{python3_sitelib}/sphinx_press_theme-%{version}-py%{python3_version}.egg-
> > info/
> 
> But it is already there. By placing the directory name with the final slash
> (/) it means the directory and all its files.

See https://fedoraproject.org/wiki/Packaging:UnownedDirectories#Common_Mistakes


Referenced Bugs:

https://bugzilla.redhat.com/show_bug.cgi?id=1815489
[Bug 1815489] python-doit fails to build in rawhide: ThemeError: no theme named
'press' found (missing theme.conf?)
-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux