[Bug 1815154] Review Request: python-sphinx-press-theme - A Sphinx-doc theme based on Vuepress

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1815154



--- Comment #5 from José Matos <jamatos@xxxxxxxx> ---
(In reply to Fabian Affolter from comment #4)
> - Wrong URL, it's the other one ;-)
> 
>   URL:            https://schettino72.github.io/sphinx_press_site/
>   Source0:        %{pypi_source}

Actually it is not possible because the source and pypi names are different:

sphinx_press_theme <- source name
sphinx-press-theme <- pypi name

Note the difference between them by swapping the underscores by dashes.

> - From my point of view both licenses must be mentioned ->
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> LicensingGuidelines/#_multiple_licensing_scenarios
> 
>   License:        MIT and BSD

You are right and I have added in the new spec.

> - The package must own the directories that are created.
> 
>   %{python3_sitelib}/sphinx_press_theme/
>  
> %{python3_sitelib}/sphinx_press_theme-%{version}-py%{python3_version}.egg-
> info/

But it is already there. By placing the directory name with the final slash (/)
it means the directory and all its files.
One reference I found
https://stackoverflow.com/questions/57385249/in-an-rpm-files-section-is-it-possible-to-specify-a-directory-and-all-of-its-fi

Searching more in detail I found it:
http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list.html

while the first paragraph here clearly states that placing the name of the
directory includes the directory and all its files:
http://ftp.rpm.org/max-rpm/s1-rpm-inside-files-list-directives.html#S3-RPM-INSIDE-DIR-DIRECTIVE

Spec URL: https://jamatos.fedorapeople.org/python-sphinx-press-theme.spec
SRPM URL:
https://jamatos.fedorapeople.org/python-sphinx-press-theme-0.5.1-3.fc32.src.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux