[Bug 226465] Merge Review: system-config-nfs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug report.

Summary: Merge Review: system-config-nfs


https://bugzilla.redhat.com/show_bug.cgi?id=226465


panemade@xxxxxxxxx changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




------- Additional Comments From panemade@xxxxxxxxx  2007-10-16 04:57 EST -------
Review:
+ package builds in mock (development i386).
+ rpmlint is silent for SRPM but Not for RPM.
system-config-nfs.noarch: W: obsolete-not-provided redhat-config-nfs
These messages can be ignored for this package.
+ source files match upstream.
8dae249bcc43a43603f3386d1761b786  system-config-nfs-1.3.32.tar.bz2
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc files present.
+ BuildRequires are proper.
+ defattr usage is correct.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code.
+ no static libraries.
+ no .pc file present.
+ no -devel subpackage exists.
+ no .la files.
+ translations are available.
+ Does owns the directories it creates.
+ no duplicates in %files.
+ file permissions are appropriate.
+ gtk-update-icon-cache scriptlets are used.
+ Desktop files are handled correctly.
+ package system-config-nfs-1.3.32-1.fc8 ->
  Provides: config(system-config-nfs) = 1.3.32-1.fc8
  Requires: /usr/bin/python config(system-config-nfs) = 1.3.32-1.fc8
hicolor-icon-theme nfs-utils pygtk2 pygtk2-libglade python >= 2.0 rhpl usermode
>= 1.36 xdg-utils
+ GUI app.

APPROVED.


-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug, or are watching the QA contact.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]