https://bugzilla.redhat.com/show_bug.cgi?id=1798798 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Flags|fedora-review? |fedora-review+ --- Comment #10 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- Looks good. XXX APPROVED XXX Please do check the Requires and Provides once. They look OK, but I don't know enough about the other OCaml packages to check them for correctness. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. ^ Look OK, but please do take a look to confirm. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [-]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen ^ I don't know what this is about, perhaps a fedora-review bug.. ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). ^ Look OK but please check once to confirm. [!]: Package functions as described. ^ Not tested, leaving this up to you :) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-ppx-deriving-4.4.1-1.fc33.x86_64.rpm ocaml-ppx-deriving-devel-4.4.1-1.fc33.x86_64.rpm ocaml-ppx-deriving-doc-4.4.1-1.fc33.noarch.rpm ocaml-ppx-deriving-debuginfo-4.4.1-1.fc33.x86_64.rpm ocaml-ppx-deriving-debugsource-4.4.1-1.fc33.x86_64.rpm ocaml-ppx-deriving-4.4.1-1.fc33.src.rpm ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US yojson -> yonks ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US protobuf -> prototype ocaml-ppx-deriving-devel.x86_64: W: no-documentation ocaml-ppx-deriving.src: W: spelling-error %description -l en_US eq -> e, q, seq ocaml-ppx-deriving.src: W: spelling-error %description -l en_US ord -> rod, or, rd ocaml-ppx-deriving.src: W: spelling-error %description -l en_US enum -> menu, en um, en-um ocaml-ppx-deriving.src: W: spelling-error %description -l en_US iter -> tier, tire, inter ocaml-ppx-deriving.src: W: spelling-error %description -l en_US yojson -> yonks ocaml-ppx-deriving.src: W: spelling-error %description -l en_US protobuf -> prototype 6 packages and 0 specfiles checked; 0 errors, 9 warnings. Rpmlint (debuginfo) ------------------- Checking: ocaml-ppx-deriving-debuginfo-4.4.1-1.fc33.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). perl: warning: Setting locale failed. perl: warning: Please check that your locale settings: LANGUAGE = (unset), LC_ALL = (unset), LC_CTYPE = "C.UTF-8", LANG = "en_GB.UTF-8" are supported and installed on your system. perl: warning: Falling back to the standard locale ("C"). ocaml-ppx-deriving-doc.noarch: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known> ocaml-ppx-deriving-debugsource.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known> ocaml-ppx-deriving-devel.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known> ocaml-ppx-deriving-devel.x86_64: W: no-documentation ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US yojson -> yonks ocaml-ppx-deriving.x86_64: W: spelling-error %description -l en_US protobuf -> prototype ocaml-ppx-deriving.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known> ocaml-ppx-deriving-debuginfo.x86_64: W: invalid-url URL: https://github.com/ocaml-ppx/ppx_deriving <urlopen error [Errno -2] Name or service not known> 5 packages and 0 specfiles checked; 0 errors, 8 warnings. Source checksums ---------------- https://github.com/ocaml-ppx/ppx_deriving/archive/v4.4.1/ppx_deriving-4.4.1.tar.gz : CHECKSUM(SHA256) this package : 27bc57774724fc4f48775f2011375a5ee1439570204abbf6607761c472757e2f CHECKSUM(SHA256) upstream package : 27bc57774724fc4f48775f2011375a5ee1439570204abbf6607761c472757e2f Requires -------- ocaml-ppx-deriving (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) ocaml(Ast_convenience) ocaml(Ast_helper) ocaml(Ast_mapper) ocaml(Build_path_prefix_map) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(Clflags) ocaml(Config) ocaml(Docstrings) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Pprintast) ocaml(Ppx_derivers) ocaml(Ppx_deriving) ocaml(Profile) ocaml(Result) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__char) ocaml(Stdlib__digest) ocaml(Stdlib__filename) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__map) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__option) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__queue) ocaml(Stdlib__result) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__string) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Warnings) ocaml(runtime) rtld(GNU_HASH) ocaml-ppx-deriving-devel (rpmlib, GLIBC filtered): ocaml-migrate-parsetree-devel(x86-64) ocaml-ppx-derivers-devel(x86-64) ocaml-ppx-deriving(x86-64) ocaml-ppx-tools-devel(x86-64) ocaml-result-devel(x86-64) ocaml-ppx-deriving-doc (rpmlib, GLIBC filtered): ocaml-ppx-deriving-debuginfo (rpmlib, GLIBC filtered): ocaml-ppx-deriving-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-ppx-deriving: ocaml(Ppx_deriving) ocaml(Ppx_deriving_create) ocaml(Ppx_deriving_enum) ocaml(Ppx_deriving_eq) ocaml(Ppx_deriving_fold) ocaml(Ppx_deriving_iter) ocaml(Ppx_deriving_make) ocaml(Ppx_deriving_map) ocaml(Ppx_deriving_ord) ocaml(Ppx_deriving_runtime) ocaml(Ppx_deriving_show) ocaml(Ppx_deriving_std) ocaml-ppx-deriving ocaml-ppx-deriving(x86-64) ocaml-ppx-deriving-devel: ocaml-ppx-deriving-devel ocaml-ppx-deriving-devel(x86-64) ocaml-ppx-deriving-doc: ocaml-ppx-deriving-doc ocaml-ppx-deriving-debuginfo: debuginfo(build-id) ocaml-ppx-deriving-debuginfo ocaml-ppx-deriving-debuginfo(x86-64) ocaml-ppx-deriving-debugsource: ocaml-ppx-deriving-debugsource ocaml-ppx-deriving-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -m fedora-rawhide-x86_64 -b 1798798 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, Ocaml Disabled plugins: Perl, PHP, Python, fonts, Haskell, Java, SugarActivity, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
