https://bugzilla.redhat.com/show_bug.cgi?id=1813713 Jerry James <loganjerry@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #2 from Jerry James <loganjerry@xxxxxxxxx> --- Thank you for the review, Jos. (In reply to Jos de Kloe from comment #1) > [!]: Requires correct, justified where necessary. > https://docs.fedoraproject.org/en-US/packaging-guidelines/GAP/ > #_requires_recommends_and_suggests > states that "Requires: gap-core" must be included. The irony of this is that I wrote the GAP guidelines. :-) I should have them amended. What is important is that a gap-pkg-* package depends on gap-core, either directly or transitively. In this case, the dependency is transitive via gap-pkg-gbnp. I have added a direct dependency on gap-core, but I will probably remove it later once I submit a revision for the guidelines. > [!]: Patches link to upstream bugs/comments/lists or are otherwise > justified. > did you report the LaTeX issue fixed by the doc patch upstream? (it is a > "should", but if not explain why) I just did: https://github.com/gap-packages/qpa/issues/48 > rplint error: > upstream should be informed about the incorrect-fsf-address error/ > See: > https://fedoraproject.org/wiki/Common_Rpmlint_issues#incorrect-fsf-address I have submitted a pull request: https://github.com/gap-packages/qpa/pull/49 I updated the spec file and the SRPM at the same URLs as above, since this is just a minor change. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
