Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ltsp-config-dhcp - DHCP configuration files for LTSP5 https://bugzilla.redhat.com/show_bug.cgi?id=330921 ------- Additional Comments From eharrison@xxxxxxxxxxxxxx 2007-10-15 23:27 EST ------- My old package added/removed "-cf /etc/ltsp-dhcpd.conf" in /etc/sysconfig/dhcpd in %post/%postun. It worked, but strikes me as horribly wrong - how many would think of looking in /etc/sysconfig/dhcpd to figure which conf file dhcpd is using? Breaking it out as a separate init script at least makes it a bit more obvious what is going on... %post CF_OPTION="-cf /etc/dhcpd-k12ltsp.conf" CONF_FILE="/etc/sysconfig/dhcpd" if [ -f $CONF_FILE -a -f /etc/dhcpd-k12ltsp.conf ] then # change dhcpd.conf.k12ltsp to dhcpd-k12ltsp.conf perl -i -p -e "s,dhcpd.conf.k12ltsp,dhcpd-k12ltsp.conf," $CONF_FILE if [ "x`grep -- -cf $CONF_FILE`" = "x" ] then . $CONF_FILE NEWARGS="$DHCPDARGS $CF_OPTION" perl -i.ltsp -p -e "s,DHCPDARGS=.*,DHCPDARGS=\"$NEWARGS\"," $CONF_FILE fi fi %postun CF_OPTION="-cf /etc/dhcpd-k12ltsp.conf" CONF_FILE="/etc/sysconfig/dhcpd" if [ -f $CONF_FILE ] then if [ "`grep -- -cf $CONF_FILE`" ] then . $CONF_FILE NEWARGS="`echo $DHCPDARGS | sed -e \"s,$CF_OPTION,,g\"`" perl -i.ltsp -p -e "s,DHCPDARGS=.*,DHCPDARGS=\"$NEWARGS\"," $CONF_FILE fi fi -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review