https://bugzilla.redhat.com/show_bug.cgi?id=1813860 --- Comment #5 from Lumír Balhar <lbalhar@xxxxxxxxxx> --- > > Requires: python3dist(pip) > > Requires: python3dist(setuptools) > > Requires: python3dist(toml) > > Why are those needed? Why are the automatic requires not working? There is > an automatic requirement on setuptools, but not on pip or toml. Is the > upstream metadata OK? toml is defined in `extras_require` but pip is not defined anywhere. I'll create an upstream issue. > > > %description > > A lightweight wrapper for pip to support Pipenv and Poetry lock files or \ > > converting them to pip-tools compatible output. > > The backslash is a possible leftover form when description was defined via a > macro. Fixed. > > # Remove bundled egg-info > > rm -rf %{name}.egg-info > > Is this needed? Why? Generated by pyp2rpm. Removed. > > # Remove shebang line from the module > > sed -i '1{\@^#!/usr/bin/env python@d}' %{buildroot}/%{python3_sitelib}/%{name}.py > > Is it possible to do this in %prep? Or does that affect both the executable > in %{_bindir} and this file? Moved to %prep. > > %{__python3} -m pytest > > The new proper way of doing this is to use %{python3} over %{__python3}. Fixed. > > %{python3_sitelib}/__pycache__/* > > %{python3_sitelib}/%{name}.py > > You can use the new %pycached macro: > > %pycached %{python3_sitelib}/%{name}.py Forgot about it. Fixed. > > %{python3_sitelib}/%{name}-%{version}-py?.?.egg-info > > This will break with Python 3.10. > Also, please use a trailing slash to ensure this is and remains a directory. > See also problems with > https://docs.fedoraproject.org/en-US/packaging-guidelines/ > Directory_Replacement/ regex changed, slash added -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
