[Bug 1812124] Review Request: python-sphinxcontrib-openapi - OpenAPI spec renderer for Sphinx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1812124



--- Comment #6 from Fabien Boucher <fboucher@xxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #4)
> Is this necessary?
> 
> sed -e '/.*use_scm_version=.*/d' \
>     -e '/.*setuptools_scm.*/d' \
>     -e '/long_description=.*/a    version="%{version}",' -i setup.py
> 

Hum in fact no. Miss that setuptools_scm is packaged in Fedora. So adding the
BR worked just fine.
Fixed.

> 
> ------------
> 
> 
> Also, %{__python3} can (should?) be replaced by %{python3}.
> 

Fixed.

> ------------
> 
> 
> The description could use more detail over summary.

Done.

> ------------
> 
> Running automated checks, will report back.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux