https://bugzilla.redhat.com/show_bug.cgi?id=1813737 Aleksei Bavshin <alebastr89@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alebastr89@xxxxxxxxx --- Comment #4 from Aleksei Bavshin <alebastr89@xxxxxxxxx> --- Bundled colorthief.py is BSD licensed. You either need to remove it and replace with dependency to 'python3-colorthief' or change license to 'GPLv3 and BSD'. Using dependency is a preferred way. https://docs.fedoraproject.org/en-US/packaging-guidelines/#bundling > Source0: %{url}/archive/v%{version}.tar.gz I believe the standard for github sources is %{url}/archive/v%{version}/%{name}-%{version}.tar.gz. Although it is a cosmetic change that only affects file name in lookaside cache. > %autosetup -n %{name}-%{version} %{name}-%{version} is already default for %autosetup. You only need to use `-n` when the toplevel directory of source archive does not match %{name}-%{version} pattern. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
