[Bug 1812905] Review Request: python-fb-re2 - python-fb-re2 is a Python extension that wraps Google's RE2 regular

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1812905



--- Comment #3 from Miro Hrončok <mhroncok@xxxxxxxxxx> ---
> Group:              Development/Libraries

Fedora packages should not use groups. 
https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections





> # Remove bundled egg-info in case it exists
> rm -rf re2.egg-info

Is this actually needed nowadays?




> %{python3_sitearch}/re2.py
> ...
> %{python3_sitearch}/__pycache__/*

Replace the two lines with one:

  %pycached %{python3_sitearch}/re2.py

https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_byte_compiling



> %{python3_sitearch}/fb_re2-*.egg-info

If this is a directory (like in this case), I suggest ending it in / to make
sure it remains a directory (there are known cases where just by changing the
buildroot content, that "file" can change to be or not be a directory, RPM is
very broken when replacing a directory with a file in an update).




The package uses setuptools at buildtime:

https://github.com/facebook/pyre2/blob/v1.0.7/setup.py#L3

But it does not BR python3-setuptools. That happens to work via a transitive
dependency only (which might in fact be removed in the future).
(See https://src.fedoraproject.org/rpms/python3/blob/master/f/python3.spec#_438
for details.)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux