https://bugzilla.redhat.com/show_bug.cgi?id=1806999 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #4 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Source0: https://github.com/dublio/cputil/releases/download/1.0/cputil-1.0.tar.gz You can use %{version} as part of the Source URL so you don't have to edit it manually each time there's a new release. >%install >rm -rf $RPM_BUILD_ROOT Don't do this. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections >%build >make %{?_smp_flags} You should call the %{set_build_flags} macro before the "make" call. ># disable producing debuginfo for this package >%global debug_package %{nil} It's a very rare circumstance when this is truly needed - all Fedora executables are built with debuginfo enabled (and then stripped to produce a -debug package). See if adding the build-flags macro (as detailed above) helps. If not, you'll have to patch the Makefile to make it respect Fedora's CFLAGS (or just call gcc directly, since it's only one file). https://docs.fedoraproject.org/en-US/packaging-guidelines/Debuginfo/#_useless_or_incomplete_debuginfo_packages_due_to_packaging_issues Looking at the upstream Makefile: >cputil: cputil.o > gcc -o cputil cputil.o -lpthread GCC is no longer part of the default buildroot. You have to add "BuildRequires: gcc". >make prefix=$RPM_BUILD_ROOT mandir=$RPM_BUILD_ROOT/%{_mandir} bindir=$RPM_BUILD_ROOT/%{_bindir} install Looking at the Makefile, the "prefix=$RPM_BUILD_ROOT" part is not needed. >%files >%{_mandir}/man1/cputil.1.gz Do not assume that man pages will be gzipped. Use a wildcard instead. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_manpages Since this is your first Fedora package - consider submitting your packages to koji (the Fedora build system) for scratch builds. https://fedoraproject.org/wiki/Using_the_Koji_build_system#Scratch_Builds -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
