[Bug 1812124] Review Request: python-sphinxcontrib-openapi - OpenAPI spec renderer for Sphinx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1812124



--- Comment #3 from Fabien Boucher <fboucher@xxxxxxxxxx> ---
(In reply to Miro Hrončok from comment #1)
>   Source0:        https://pypi.io/packages/source/%(c=%{pypi_name}; echo
> ${c:0:1})/%{pypi_name}/%{pypi_name}-%{version}.tar.gz
> 
> There is a amcor:
> 
>   Source0:        %{pypi_source}
> 
> --------------------------
> 
>   %build
>   %{__python3} setup.py build
>   
>   %install
>   %{__python3} setup.py install -O1 --skip-build --root %{buildroot}
> 
> 
> This should nowdays be:
> 
> 
>   %build
>   %py3_build
>   
>   %install
>   %py3_install
> 

fixed.

> --------------------------
> 
>   Requires:       python3-sphinxcontrib-httpdomain
>   Requires:       python3-jsonschema
>   Requires:       python3-pyyaml
> 
> This should use the automatic dependencies instead (possibly by not deleting
> the requirements.txt file?)
> 

Yes it worked:

[root@fedora31-packaging python-sphinxcontrib-openapi]# dnf deplist
results_python-sphinxcontrib-openapi/0.6.0/1.fc33/python3-sphinxcontrib-openapi-0.6.0-1.fc33.noarch.rpm
Last metadata expiration check: 1:58:54 ago on Fri 13 Mar 2020 08:34:01 AM UTC.
package: python3-sphinxcontrib-openapi-0.6.0-1.fc33.noarch
  dependency: python(abi) = 3.8
  dependency: python3.8dist(jsonschema) >= 2.5.1
  dependency: python3.8dist(pyyaml) >= 3.12
  dependency: python3.8dist(sphinxcontrib-httpdomain) >= 1.5
  dependency: rpmlib(CompressedFileNames) <= 3.0.4-1
  dependency: rpmlib(FileDigests) <= 4.6.0-1
  dependency: rpmlib(PartialHardlinkSets) <= 4.0.4-1
  dependency: rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  dependency: rpmlib(PayloadIsZstd) <= 5.4.18-1


> 
> --------------------------
> 
> 
> The two "initial packaging" changelog entries are confusing.

fixed.



Scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=42445205

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux