https://bugzilla.redhat.com/show_bug.cgi?id=1812857 --- Comment #6 from Fabien Boucher <fboucher@xxxxxxxxxx> --- (In reply to Miro Hrončok from comment #5) > > not sure setup.py is using them > > Sounds like a fix for upstream? > Yes, I'll see how upstream is responsive with the Compat 3.7 3.8 patch first. > > > I move (Cython) to a BuildRequirements > > Why not drop it if it is not used? It seems like it is either a test only > requirement, or a leftover. > I've dropped it even in unit tests it seems not used. > > > %check > > %{__python3} -c "import ws4py" > > Have you tired running the tests with pytest? > https://github.com/Lawouach/WebSocket-for-Python/blob/master/.travis.yml I've added the unit tests run in %check. https://koji.fedoraproject.org/koji/taskinfo?taskID=42444154 -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx