https://bugzilla.redhat.com/show_bug.cgi?id=1812675 Artur Iwicki <fedora@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxx Doc Type|--- |If docs needed, set a value --- Comment #1 from Artur Iwicki <fedora@xxxxxxxxxx> --- >Version: 0.0.20200310git >Release: 1%{?dist} If upstream has not decided on a version number, you should use 0 for the version and put the date+gitinfo in the Release tag. https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots In ws_python3_explicitly.patch: >-#!/usr/bin/env python >+#!/usr/bin/env python3 Do not use /usr/bin/env. Always specify the interpreter explicitly. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_shebang_lines >install -m 755 contribs/ws_prepare %{buildroot}/usr/sbin/ws_prepare 1. Use %{_sbindir} here instead of "/usr/sbin". 2. Use the "-p" option to preserve the timestamp. Some non-technical nitpicks: >Summary: A tool to create scratch directories by users with an expiration date English makes it easy to create ambiguous sentences, but this one sounds like it allows users with an expiration date to create directories. I'd be worried if a user had an expiration date. ;) >%description >A **workspace** is a directory created in behalf of a user, associated with a >expiration date, to prevent disks from uncontrolled filling. Should be "_an_ expiration date". -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
