https://bugzilla.redhat.com/show_bug.cgi?id=1812857 --- Comment #2 from Miro Hrončok <mhroncok@xxxxxxxxxx> --- %build %{__python3} setup.py build %install %{__python3} setup.py install -O1 --skip-build --root %{buildroot} This should nowdays be: %build %py3_build %install %py3_install -------------------------- Requires: python3-setuptools Requires: python3-cherrypy Requires: python3-tornado Requires: python3-greenlet Requires: python3-gevent This should use the automatic dependencies instead (possibly by not deleting the requirements.txt file?) -------------------------- Requires: Cython Same as above + this should be python3-Cython + why there is a runtime dependency on Cython? -------------------------- Patch01: 0001-Python-3.7-and-3.8-compat.patch This is quite hidden. Could it be moved to the source please? Is there an upstream PR link? -------------------------- %defattr(644,root,root,755) Why is this needed? -------------------------- %{python3_sitelib}/* This is explicitly discouraged in the guidelines. https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_files_to_include -------------------------- The two "initial packaging" changelog entries are confusing. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
