[Bug 1807224] Review Request: xsecurelock - X11 screen lock utility with security in mind

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1807224



--- Comment #2 from Sam P <dagofthedofg@xxxxxxxxx> ---
Spec URL:
https://copr-be.cloud.fedoraproject.org/results/survient/xsecurelock/fedora-rawhide-x86_64/01299154-xsecurelock/xsecurelock.spec
SRPM URL:
https://copr-be.cloud.fedoraproject.org/results/survient/xsecurelock/fedora-rawhide-x86_64/01299154-xsecurelock/xsecurelock-1.7.0-1.fc33.src.rpm

Thank you Zbigniew. I've corrected almost all of the items you outlined except
I'm having trouble with repeating the same file in %doc and %license,
specifically the LICENSE file itself. When I remove:

%doc LICENSE

from my spec file I get the following error:

Provides: xsecurelock = 1.7.0-1.fc31 xsecurelock(x86-64) = 1.7.0-1.fc31
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Requires: /usr/bin/sh libX11.so.6()(64bit) libXcomposite.so.1()(64bit)
libXext.so.6()(64bit) libXfixes.so.3()(64bit) libXmuu.so.1()(64bit)
libXrandr.so.2()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit)
libc.so.6(GLIBC_2.15)(64bit) libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.25)(64bit) libc.so.6(GLIBC_2.3.4)(64bit)
libc.so.6(GLIBC_2.4)(64bit) libm.so.6()(64bit) libm.so.6(GLIBC_2.2.5)(64bit)
libm.so.6(GLIBC_2.29)(64bit) libpam.so.0()(64bit)
libpam.so.0(LIBPAM_1.0)(64bit) rtld(GNU_HASH)
Processing files: xsecurelock-debugsource-1.7.0-1.fc31.x86_64
Provides: xsecurelock-debugsource = 1.7.0-1.fc31
xsecurelock-debugsource(x86-64) = 1.7.0-1.fc31
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Processing files: xsecurelock-debuginfo-1.7.0-1.fc31.x86_64
Provides: debuginfo(build-id) = 5f5e735d74e645e05110092c1286278060f9fa8c
debuginfo(build-id) = 62f6b46f8b836558d85c01ad1771c1556204f849
debuginfo(build-id) = 82184a458189f5e727be1815b691e743075d4117
debuginfo(build-id) = 9375a666b0fb5b5d229e75a13cae114096a64d08
debuginfo(build-id) = 9c0daf8e8593bbaf2a812a8cf08d8dc47e58bf7c
debuginfo(build-id) = c50911ffaee8d3a9f5f22ef5f371a0df72fe1ecf
debuginfo(build-id) = cde1278cec731a2ebdcbbfb180dd740ebe04c71e
xsecurelock-debuginfo = 1.7.0-1.fc31 xsecurelock-debuginfo(x86-64) =
1.7.0-1.fc31
Requires(rpmlib): rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <=
4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
Recommends: xsecurelock-debugsource(x86-64) = 1.7.0-1.fc31
Checking for unpackaged file(s): /usr/lib/rpm/check-files
/builddir/build/BUILDROOT/xsecurelock-1.7.0-1.fc31.x86_64
error: Installed (but unpackaged) file(s) found:
   /usr/share/doc/xsecurelock/LICENSE


RPM build errors:
    Installed (but unpackaged) file(s) found:
   /usr/share/doc/xsecurelock/LICENSE
Finish: rpmbuild xsecurelock-1.7.0-1.fc31.src.rpm
Finish: build phase for xsecurelock-1.7.0-1.fc31.src.rpm
ERROR: Exception(./xsecurelock-1.7.0-1.fc31.src.rpm) Config(fedora-31-x86_64) 0
minutes 33 seconds
INFO: Results and/or logs in: ./
INFO: Cleaning up build root ('cleanup_on_failure=True')
Start: clean chroot
Finish: clean chroot
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M cca504938969409e9708389a4ec73f78 -D
/var/lib/mock/fedora-31-x86_64/root -a --capability=cap_ipc_lock
--bind=/tmp/mock-resolv.tuas78fo:/etc/resolv.conf --setenv=TERM=vt100
--setenv=SHELL=/bin/bash --setenv=HOME=/builddir --setenv=HOSTNAME=mock
--setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin --setenv=PROMPT_COMMAND=printf
"\033]0;<mock-chroot>\007" --setenv=PS1=<mock-chroot> \s-\v\$ 
--setenv=LANG=en_US.utf8 -u mockbuild bash --login -c /usr/bin/rpmbuild -bb
--target x86_64 --nodeps /builddir/build/originals/xsecurelock.spec

It does appear to be a new TLD, it resolves against the caching nameserver I'm
using. I can switch it to the github page if needed. Appreciate the guidance
and assistance.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux