https://bugzilla.redhat.com/show_bug.cgi?id=1811485 Guido Aulisi <guido.aulisi@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |guido.aulisi@xxxxxxxxx --- Comment #2 from Guido Aulisi <guido.aulisi@xxxxxxxxx> --- Happy to see this package unretired, I add some quick findings: 1) To fix python shebangs you can use: BuildRequires: %{_bindir}/pathfix.py ... %prep ... # Fix unversioned python shebangs pathfix.py -pni %{_bindir}/python3 waf wscript ... 2) Your are not settings LDFLAGS, you could add this macro (%set_build_flags) that sets all flags, then add custom ones, and maybe this is more readable: >%build >%ifarch %{ix86} x86_64 >CXXFLAGS="%{optflags} -std=c++11" ./waf configure --prefix=%{_prefix} --libdir=%{_libdir} >%else >CXXFLAGS="%{optflags} -std=c++11" ./waf configure --prefix=%{_prefix} --libdir=%{_libdir} --disable-sse >%endif %build %set_build_flags CXXFLAGS+=" -std=c++11" // I thinks g++ defaults to c++11 so it could be omitted ./waf configure --prefix=%{_prefix} --libdir=%{_libdir} \ %ifarch %{ix86} x86_64 %else --disable-sse %endif 3) Use license tag >%doc COPYING %license COPYING -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
