[Bug 1809097] Review Request: php-marcusschwarz-lesserphp - a LESS compiler written in PHP

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1809097

Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |zbyszek@xxxxxxxxx
           Assignee|nobody@xxxxxxxxxxxxxxxxx    |zbyszek@xxxxxxxxx
              Flags|                            |fedora-review?



--- Comment #3 from Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> ---
Obsoletes is wrong: php-lessphp-0.5.0-11.fc32 is the latest, so you need
something like
Obsoletes: php-lessphp < 0.5.0+0

Including the version in the spec file name seems wrong.

+ package name is OK (please rename the spec file)
+ latest version
+ license is acceptable (MIT (or GPLv3))
+ license is specified correctly
+ build and installs OK
+ fedora-review and rpmlint seem happy
+ Provides/Requires/BuildRequires look OK

rpmlint says:
E: description-line-too-long C It is designed to be compatible with less.js
(https://lesscss.org/), and suitable
→ please wrap.

php-marcusschwarz-lesserphp.src:65: W: mixed-use-of-spaces-and-tabs (spaces:
line 1, tab: line 65)

$ /usr/bin/plessc
PHP Fatal error:  Uncaught Error: Class 'lessc' not found in /usr/bin/plessc:47
Stack trace:
#0 {main}
  thrown in /usr/bin/plessc on line 47
→ that doesn't seem right :(

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux