[Bug 1810902] Review Request: rpkg-macros - Set of preproc macros for rpm packages

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1810902



--- Comment #7 from clime7@xxxxxxxxx ---
Ah, I only thought about fixing bin/pack_sources permissions which were 775 and
i changed it to 755.

# fix for rpmlint permission errors
chmod a+x %{buildroot}%{libdir}/rpkg.macros.d/*.bash
chmod a+x %{buildroot}%{libdir}/rpkg.macros.d/library/*.bash

I am not so sure about this cause, as you said, these files are only intended
to be sourced - not executed (as they only contain functions and not a direct
bash code). They contain #!/bin/bash but that's just because the linter i use
doesn't like when it is missing and I think it is also not so bad bad practice
to put the shebang everywhere (even into files which will be just sourced).

Can you, please, take a look again if the executable permissions are really
needed on the files you mention? I think the rpmlint tool might not be 100% to
the point there.

I am trying a little bit of negotiation here :).

Thank you
clime

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux