https://bugzilla.redhat.com/show_bug.cgi?id=1804683 --- Comment #3 from Jan Grulich <jgrulich@xxxxxxxxxx> --- - Fix compiler flags. You might want to use %make_build and %make_install See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_compiler_flags → Fixed - There are license issues. One of the files has a different license, I have attached a report. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/ → Fixed - Libraries do not follow naming conventions. I think the ones under qt5/plugins are fine, but I don't think that libkbolt is ok. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_downstream_so_name_versioning - libkbolt should be a subpackage See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_mixed_use_packages → Won't fix, libkbolt is a QML plugin, it's not meant to be used outside plasma-thunderbolt. - Consider adding readme to %doc See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_documentation → Fixed - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ → Fixed - Package installs a %{name}.desktop using desktop-file-install or desktop- file-validate if there is such a file. → Won't fix, it's a service file for a KCM module, not for an application, it won't pass the validation - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/kpackage/kcms/kcm_bolt See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files → Fixed -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
