Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cyrus-imapd - high-performance mail server (IMAP, POP3, ...) https://bugzilla.redhat.com/show_bug.cgi?id=231861 tjanouse@xxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-cvs+ |fedora-cvs? ------- Additional Comments From tjanouse@xxxxxxxxxx 2007-10-15 12:45 EST ------- Lubo, Thanks for your comments and sorry for the delay. Me not like reviews, you know. I did a few changes as you suggested: http://cvs.fedora.redhat.com/viewcvs/devel/cyrus-imapd/cyrus-imapd.spec?root=extras&r1=1.32&r2=1.33 And I have a few comments: Ad 2). I'd like to leave the HTML docs in the main package, but you may try to convince me. I don't think we should delete the HTML manpages though, because they are linked from the HTML docs. Ad 3). As you pointed out, there are no shared libs in the package. libcyrus is intended to be linked statically and that's what is in the -devel subpackage. Ad 4). I fixed these and about 1 other, will maybe fix others later. There has been a change in the License field since, re-review this, please. And, the most important thing: This package has a whole lot of files in /usr/lib/cyrus-imapd, regardless of the architecture. This used to be a reason for marking it multiarch and warning about multiarch collisions. It's been added to a list of exceptions since then. But the question remains -- should I leave it that way, or should I make some effort to move those to /usr/libexec (or something similar)? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review