https://bugzilla.redhat.com/show_bug.cgi?id=1801352 Ralf Senderek <fedora@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxx --- Comment #12 from Ralf Senderek <fedora@xxxxxxxxxxx> --- When I run fedora-review these are the points where I don't see a "Pass" at the moment. [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [?]: Package obeys FHS, except libexecdir and /usr/target. [?]: Requires correct, justified where necessary. [?]: Package complies to the Packaging Guidelines [!]: Uses parallel make %{?_smp_mflags} macro. [?]: Package functions as described. [?]: Patches link to upstream bugs/comments/lists or are otherwise [?]: %check is present and all tests pass. 1) REQUIRES Having looked at the source code, I found that everything is pure python, so no C-code is involved. One program is using git and another uses xdotool, so I think that the Requires-section has to be updated with at least python3, git and xdotool, maybe there are other dependencies that I haven't spotted yet. If "jack-audio-connection-kit" would be neccessary for proper funktionality, it must also be required. 2) Filenames There is a file packaged as 'snapshot explain' tha should have a name without a blank. Raysession creates a directory 'Ray Session' in the user's home directory, which will also be safer if the blank is deleted. 3) man pages "If some man pages are absent, packagers SHOULD work with upstream to add them." I assume that all three "binaries" in /usr/bin should be invoked by users not only other programs, so man pages would be beneficial. If they exist, they can be additional SOURCE files. 4) Running the binary "raysession" I tried to run raysession on F32 and got a lot of errors regarding qt5 and Wayland. To make sure users have a professional experience in using the software I advise to check any runtime error messages that may be caused by missing dependencies (not yet spotted). Here is some work to be done. 5) "Binaries" The package installs three binaries in /usr/bin that call exec and point into /usr/share/%{name} where the python source code is located under /usr/share/%{name}/src. I really don't know if that is allowed, so you may ask on the devel list about the proper location for the src-files. My point of view would be that %{_libdir}/%{name}/ is more appropriate than %{_datadir}/%{name}/. But maybe your location is permissible, I dont't know. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
