https://bugzilla.redhat.com/show_bug.cgi?id=1789146 Neal Gompa <ngompa13@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |needinfo?(ngompa13@xxxxxxxx | |m) | --- Comment #8 from Neal Gompa <ngompa13@xxxxxxxxx> --- Review notes: * Package is named somewhat appropriately. It's essentially a fictitious source package to not conflict with the real one in RHEL 8, so that's fine. * The licensing matches up with the main package it was split from (systemd) * The package builds and installs successfully * There are no notable issues from rpmlint beyond what's always been there from systemd * Packaging generally follows Fedora/EPEL packaging guidelines There's only a minor issue that you can resolve on import: "%{_localstatedir}/lib" should just be "%{_sharedstatedir}". Otherwise looks good to me. 😵 PACKAGE APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
