https://bugzilla.redhat.com/show_bug.cgi?id=1773720 --- Comment #8 from Brandon Perkins <bperkins@xxxxxxxxxx> --- (In reply to Brandon Perkins from comment #6) > > [ ]: Each %files section contains %defattr if rpm < 4.4 > > Note: %defattr present but not needed > > Fixed with 1.2.4-6. > > Fixed, but there is no line for this in the new review report. $ grep %defattr SPECS/golang-github-haproxytech-dataplaneapi.spec > > [ ]: Spec use %global instead of %define unless justified. > > Note: %define requiring justification: %define gorepo dataplaneapi, > > %define haproxy_user haproxy, %define haproxy_group %{haproxy_user}, > > %define haproxy_homedir %{_localstatedir}/lib/haproxy > > Fixed with 1.2.4-6. > > Fixed: [x]: Spec use %global instead of %define unless justified. $ grep -E "%(global|define)" SPECS/golang-github-haproxytech-dataplaneapi.spec %global gorepo dataplaneapi %global haproxy_user haproxy %global haproxy_group %{haproxy_user} %global haproxy_homedir %{_localstatedir}/lib/haproxy %global _hardened_build 1 %global goipath github.com/haproxytech/dataplaneapi %global common_description %{expand: %global golicenses LICENSE %global godocs README.md CONTRIBUTING.md -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
