[Bug 1773720] Review Request: golang-github-haproxytech-dataplaneapi - HAProxy Data Plane API

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1773720



--- Comment #6 from Brandon Perkins <bperkins@xxxxxxxxxx> ---
Trying to get ahead of any issues, I went through the fedora-review report for
all five packages as they exist now and provided comments where needed:

> ===== MUST items =====
> 
> Generic:
> [ ]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.

$ rpm -q --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm
SRPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.src.rpm
golang-github-haproxytech-dataplaneapi: ASL 2.0
golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0
golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0
golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
golang-github-haproxytech-dataplaneapi: ASL 2.0


> [ ]: License field in the package spec file matches the actual license.
>      Note: There is no build directory. Running licensecheck on vanilla
>      upstream sources. Licenses found: "Unknown or generated". 4 files have
>      unknown license. Detailed output of licensecheck in
>      ~/git/haproxytech/1773720-golang-github-haproxytech-
>      dataplaneapi/licensecheck.txt



Unknown or generated
--------------------
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz

$ rpm -qpL RPMS/golang-github-haproxytech-dataplaneapi-*.rpm
/usr/share/licenses/golang-github-haproxytech-dataplaneapi/LICENSE
/usr/share/licenses/golang-github-haproxytech-dataplaneapi-devel/LICENSE
$ tar -tf
1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz
| grep /LICENSE$
dataplaneapi-1.2.4/LICENSE
$ tar -xvzf
1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source0/dataplaneapi-1.2.4.tar.gz
dataplaneapi-1.2.4/LICENSE
dataplaneapi-1.2.4/LICENSE
$ rpm -qp --queryformat="%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-*.rpm
golang-github-haproxytech-dataplaneapi: ASL 2.0
golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0
golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0
golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
$ licensecheck dataplaneapi-1.2.4/LICENSE
dataplaneapi-1.2.4/LICENSE: *No copyright* Apache License (v2.0)
$ grep '^# Upstream license specification: '
1773720-golang-github-haproxytech-dataplaneapi/srpm-unpacked/golang-github-haproxytech-dataplaneapi.spec 
# Upstream license specification: Apache-2.0


~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source1/dataplaneapi.service
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source2/dataplaneapi.logrotate
~/git/haproxytech/1773720-golang-github-haproxytech-dataplaneapi/upstream-unpacked/Source3/dataplaneapi.sysconfig

Not Applicable for dataplaneapi.service, dataplaneapi.logrotate, and
dataplaneapi.sysconfig.

> [ ]: License file installed when any subpackage combination is installed.

$ rpm -qpL --queryformat="\n%{NAME}: %{LICENSE}\n"
RPMS/golang-github-haproxytech-dataplaneapi-*.rpm

golang-github-haproxytech-dataplaneapi: ASL 2.0
/usr/share/licenses/golang-github-haproxytech-dataplaneapi/LICENSE

golang-github-haproxytech-dataplaneapi-debuginfo: ASL 2.0

golang-github-haproxytech-dataplaneapi-debugsource: ASL 2.0

golang-github-haproxytech-dataplaneapi-devel: ASL 2.0
/usr/share/licenses/golang-github-haproxytech-dataplaneapi-devel/LICENSE

$ for r in $(ls RPMS/golang-github-haproxytech-dataplaneapi-*.rpm); do for d in
conflicts enhances obsoletes provides recommends requires suggests supplements;
do o=$(rpm -qp --${d} ${r} | grep dataplaneapi); if [ "${o}" != "" ]; then echo
-e "=== ${r} ${d} ===\n${o}\n"; fi; done; done
=== RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
provides ===
config(golang-github-haproxytech-dataplaneapi) = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi(x86-64) = 1.2.4-5.fc31

=== RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
requires ===
config(golang-github-haproxytech-dataplaneapi) = 1.2.4-5.fc31

===
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
provides ===
golang-github-haproxytech-dataplaneapi-debuginfo = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi-debuginfo(x86-64) = 1.2.4-5.fc31

===
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
recommends ===
golang-github-haproxytech-dataplaneapi-debugsource(x86-64) = 1.2.4-5.fc31

===
RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
provides ===
golang-github-haproxytech-dataplaneapi-debugsource = 1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi-debugsource(x86-64) = 1.2.4-5.fc31

=== RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm
provides ===
golang(github.com/haproxytech/dataplaneapi) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/adapters) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/handlers) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/haproxy) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/misc) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/acl) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/backend) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/backend_switching_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/bind) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/configuration) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/defaults) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/discovery) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/filter) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/frontend) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/global) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/http_request_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/http_response_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/information) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/log_target) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/reloads) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/server) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/server_switching_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/sites) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/specification) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/stats) = 1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/stick_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/tcp_request_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/tcp_response_rule) =
1.2.4-5.fc31
golang(github.com/haproxytech/dataplaneapi/operations/transactions) =
1.2.4-5.fc31
golang-github-haproxytech-dataplaneapi-devel = 1.2.4-5.fc31
golang-ipath(github.com/haproxytech/dataplaneapi) = 1.2.4-5.fc31



> [ ]: Package must own all directories that it creates.
>      Note: Directories without known owners: /etc/logrotate.d

The /etc/logrotate.d directory is owned by the 'logrotate' package:

$ rpm -qf /etc/logrotate.d
logrotate-3.15.1-1.fc31.x86_64

This issue is properly satisfied by the logrotate 'Suggests' in the RPM:

$ grep ^Suggests: SPECS/golang-github-haproxytech-dataplaneapi.spec 
Suggests: logrotate
$ rpm -qp --suggests
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm 
logrotate


> [ ]: Package does not own files or directories owned by other packages.
>      Note: Dirs in package are owned also by:

<snip/>

This is an issue across all 'golang-github' packages.  In reality, the
'/usr/share/gocode/src/github.com' directory should only be owned by the
'golang' package itself:

$ rpm -qf /usr/share/gocode/src/github.com
golang-1.13.6-1.fc31.x86_64


> [ ]: %build honors applicable compiler flags or justifies otherwise.

The %build section only compiles code via the %gobuild macro:

$ grep -A7 ^%build SPECS/golang-github-haproxytech-dataplaneapi.spec
%build
for cmd in cmd/* ; do
  %gobuild -o %{gobuilddir}/sbin/$(basename $cmd) %{goipath}/$cmd
done
mkdir -p %{gobuilddir}/share/man/man8
help2man -n "%{summary}" -s 8 -o %{gobuilddir}/share/man/man8/%{gorepo}.8 -N
--version-string="%{version}" %{gobuilddir}/sbin/%{gorepo}
gzip %{gobuilddir}/share/man/man8/%{gorepo}.8



> [ ]: Package contains no bundled libraries without FPC exception.

None:

$ rpm -qp --provides
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm | grep
bundled
$ rpm -qp --provides
RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm |
grep bundled
$ rpm -qp --provides
RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
| grep bundled
$ rpm -qp --provides
RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm |
grep bundled


> [ ]: Changelog in prescribed format.

Should all be fixed now.

> [ ]: Sources contain only permissible code or content.

Yes.

> [ ]: Each %files section contains %defattr if rpm < 4.4
>      Note: %defattr present but not needed

Fixed with 1.2.4-6.


> [ ]: Package contains desktop file if it is a GUI application.

Not Applicable.

> [ ]: Development files must be in a -devel package

RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm


> [ ]: Package uses nothing in %doc for runtime.

None:

golang-github-haproxytech-dataplaneapi:
/usr/share/doc/golang-github-haproxytech-dataplaneapi/CONTRIBUTING.md
/usr/share/doc/golang-github-haproxytech-dataplaneapi/README.md
/usr/share/man/man8/dataplaneapi.8.gz

golang-github-haproxytech-dataplaneapi-debuginfo:

golang-github-haproxytech-dataplaneapi-debugsource:

golang-github-haproxytech-dataplaneapi-devel:
/usr/share/doc/golang-github-haproxytech-dataplaneapi-devel/CONTRIBUTING.md
/usr/share/doc/golang-github-haproxytech-dataplaneapi-devel/README.md
/usr/share/gocode/src/github.com/haproxytech/dataplaneapi/CONTRIBUTING.md
/usr/share/gocode/src/github.com/haproxytech/dataplaneapi/README.md



> [ ]: Package consistently uses macros (instead of hard-coded directory
>      names).

Yes.

> [ ]: Package is named according to the Package Naming Guidelines.

Yes.

> [ ]: Package does not generate any conflict.

None.

> [ ]: Package obeys FHS, except libexecdir and /usr/target.

Yes.

> [ ]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.

Not Applicable.

> [ ]: Requires correct, justified where necessary.

Yes:

golang-github-haproxytech-dataplaneapi:
/bin/sh
config(golang-github-haproxytech-dataplaneapi) = 1.2.4-5.fc31
haproxy >= 1.9
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libpthread.so.0()(64bit)
libpthread.so.0(GLIBC_2.2.5)(64bit)
libpthread.so.0(GLIBC_2.3.2)(64bit)
rtld(GNU_HASH)
systemd

golang-github-haproxytech-dataplaneapi-debuginfo:

golang-github-haproxytech-dataplaneapi-debugsource:

golang-github-haproxytech-dataplaneapi-devel:
go-filesystem
golang(github.com/GehirnInc/crypt)
golang(github.com/GehirnInc/crypt/md5_crypt)
golang(github.com/GehirnInc/crypt/sha256_crypt)
golang(github.com/GehirnInc/crypt/sha512_crypt)
golang(github.com/docker/go-units)
golang(github.com/go-openapi/errors)
golang(github.com/go-openapi/loads)
golang(github.com/go-openapi/runtime)
golang(github.com/go-openapi/runtime/flagext)
golang(github.com/go-openapi/runtime/middleware)
golang(github.com/go-openapi/runtime/security)
golang(github.com/go-openapi/spec)
golang(github.com/go-openapi/strfmt)
golang(github.com/go-openapi/swag)
golang(github.com/go-openapi/validate)
golang(github.com/haproxytech/client-native)
golang(github.com/haproxytech/client-native/configuration)
golang(github.com/haproxytech/client-native/runtime)
golang(github.com/haproxytech/config-parser)
golang(github.com/haproxytech/config-parser/types)
golang(github.com/haproxytech/models)
golang(github.com/jessevdk/go-flags)
golang(github.com/rs/cors)
golang(github.com/shirou/gopsutil/host)
golang(github.com/shirou/gopsutil/mem)
golang(github.com/sirupsen/logrus)
golang(golang.org/x/net/netutil)
golang(golang.org/x/sys/unix)



> [ ]: Spec file is legible and written in American English.

Yes.

> [ ]: Package contains systemd file(s) if in need.

Yes:

$ rpm -qpl RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
| grep systemd
/usr/lib/systemd/system/dataplaneapi.service
$ ls SOURCES/dataplaneapi.service 
SOURCES/dataplaneapi.service
$ rpm -qp --requires
RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm | grep
systemd
systemd
systemd
systemd
$ grep systemd SPECS/golang-github-haproxytech-dataplaneapi.spec
BuildRequires:  systemd-units
Requires(post):   systemd
Requires(preun):  systemd
Requires(postun): systemd
%systemd_post %{gorepo}.service
%systemd_preun %{gorepo}.service
%systemd_postun_with_restart %{gorepo}.service
- Implement systemd


> [ ]: Useful -debuginfo package or justification otherwise.

Yes.

> [ ]: Package is not known to require an ExcludeArch tag.

ExcludeArch tag not required.

> [ ]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 40960 bytes in 4 files.

Not needed as 40960 bytes is less than 1MB.

> [ ]: Package complies to the Packaging Guidelines

Yes.

> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
> [x]: Package installs properly.
> [x]: Rpmlint is run on all rpms the build produces.
>      Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
> [x]: %config files are marked noreplace or the reason is justified.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: No %config files under /usr.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: systemd_post is invoked in %post, systemd_preun in %preun, and
>      systemd_postun in %postun for Systemd service files.
>      Note: Systemd service file(s) in golang-github-haproxytech-
>      dataplaneapi
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> ===== SHOULD items =====
> 
> Generic:
> [ ]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.

Good.

> [ ]: Final provides and requires are sane (see attachments).

Good.

> [ ]: Fully versioned dependency in subpackages if applicable.
>      Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in golang-
>      github-haproxytech-dataplaneapi-devel

Not Applicable.

> [ ]: Package functions as described.

Yes.

> [ ]: Latest version is packaged.

Yes.

> [ ]: Package does not include license text files separate from upstream.

No additional license text files.

> [ ]: Sources are verified with gpgverify first in %prep if upstream
>      publishes signatures.
>      Note: gpgverify is not used.

Not available.

> [ ]: Description and summary sections in the package spec file contains
>      translations for supported Non-English languages, if available.

Not available.

> [ ]: %check is present and all tests pass.

Yes:

$ grep -B1 -A3 -E "(^%check| check$)"
SPECS/golang-github-haproxytech-dataplaneapi.spec
%bcond_without check

%define gorepo          dataplaneapi
%define haproxy_user    haproxy
--
%if %{with check}
%check
%gocheck
%endif



> [ ]: Packages should try to preserve timestamps of original installed
>      files.

Good:

$ date ; LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- "ls -ld \$(rpm -qL
golang-github-haproxytech-dataplaneapi)"
Wed 04 Mar 2020 02:50:25 PM EST
-rw-r--r--. 1 root root 10173 Oct  9 09:36
/usr/share/licenses/golang-github-haproxytech-dataplaneapi/LICENSE
$ date ; LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- "ls -ld \$(rpm -qL
golang-github-haproxytech-dataplaneapi-debuginfo)"
Wed 04 Mar 2020 02:50:27 PM EST
dr-xr-xr-x. 18 root root 4096 Mar  3 17:43 .
$ date ; LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- "ls -ld \$(rpm -qL
golang-github-haproxytech-dataplaneapi-debugsource)"
Wed 04 Mar 2020 02:50:29 PM EST
dr-xr-xr-x. 18 root root 4096 Mar  3 17:43 .
$ date ; LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- "ls -ld \$(rpm -qL
golang-github-haproxytech-dataplaneapi-devel)"
Wed 04 Mar 2020 02:50:30 PM EST
-rw-r--r--. 1 root root 10173 Oct  9 09:36
/usr/share/licenses/golang-github-haproxytech-dataplaneapi-devel/LICENSE


> [ ]: Spec use %global instead of %define unless justified.
>      Note: %define requiring justification: %define gorepo dataplaneapi,
>      %define haproxy_user haproxy, %define haproxy_group %{haproxy_user},
>      %define haproxy_homedir %{_localstatedir}/lib/haproxy

Fixed with 1.2.4-6.


> [x]: Reviewer should test that the package builds in mock.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: SourceX is a working URL.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
> 
> ===== EXTRA items =====
> 
> Generic:
> [x]: Rpmlint is run on debuginfo package(s).
>      Note: No rpmlint messages.
> [x]: Rpmlint is run on all installed packages.
>      Note: There are rpmlint messages (see attachment).
> [x]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
> [x]: Spec file according to URL is the same as in SRPM.
> 
> 
> Rpmlint
> -------
> Checking: golang-github-haproxytech-dataplaneapi-1.2.4-5.fc33.x86_64.rpm
>           golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc33.noarch.rpm
>           golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc33.x86_64.rpm
>           golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc33.x86_64.rpm
>           golang-github-haproxytech-dataplaneapi-1.2.4-5.fc33.src.rpm
> golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath

Expected.

> golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi.

Allowed for '-debuginfo' and '-debugsource' sub-packages.

> 5 packages and 0 specfiles checked; 1 errors, 1 warnings.
> 
> 
> 
> 
> Rpmlint (debuginfo)
> -------------------
> Checking: golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc33.x86_64.rpm
> 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
> 
> 
> 
> 
> 
> Rpmlint (installed packages)
> ----------------------------
> golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E: description-line-too-long C This package provides debug sources for package golang-github-haproxytech-dataplaneapi.
> golang-github-haproxytech-dataplaneapi-debugsource.x86_64: W: invalid-url URL: https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or service not known>
> golang-github-haproxytech-dataplaneapi.x86_64: W: invalid-url URL: https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or service not known>
> golang-github-haproxytech-dataplaneapi-debuginfo.x86_64: W: invalid-url URL: https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or service not known>
> golang-github-haproxytech-dataplaneapi-devel.noarch: W: invalid-url URL: https://github.com/haproxytech/dataplaneapi <urlopen error [Errno -2] Name or service not known>
> golang-github-haproxytech-dataplaneapi-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/haproxytech/dataplaneapi/.goipath
> 4 packages and 0 specfiles checked; 1 errors, 5 warnings.
>

$ sudo mkdir -p /var/lib/mock/fedora-rawhide-x86_64/root/root/.config
$ echo "addFilter(r\"hidden-file-or-dir
/usr/share/gocode/src/github\.com/.*/.*/.goipath$\")" > /tmp/rpmlint.config
$ sudo cp /tmp/rpmlint.config
/var/lib/mock/fedora-rawhide-x86_64/root/root/.config/rpmlint
$ LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- rpmlint -f
/root/.config/rpmlint golang-github-haproxytech-dataplaneapi
golang-github-haproxytech-dataplaneapi-debuginfo
golang-github-haproxytech-dataplaneapi-debugsource
golang-github-haproxytech-dataplaneapi-devel
golang-github-haproxytech-dataplaneapi-debugsource.x86_64: E:
description-line-too-long C This package provides debug sources for package
golang-github-haproxytech-dataplaneapi.
4 packages and 0 specfiles checked; 1 errors, 0 warnings.


> 
> 
> Source checksums
> ----------------
> https://github.com/haproxytech/dataplaneapi/archive/v1.2.4/dataplaneapi-1.2.4.tar.gz :
>   CHECKSUM(SHA256) this package     : e1791a5475485cb7520d5102509614d072781fc576481eca128e96607c43e12c
>   CHECKSUM(SHA256) upstream package : e1791a5475485cb7520d5102509614d072781fc576481eca128e96607c43e12c
> 
> 
> Requires
> --------
> golang-github-haproxytech-dataplaneapi (rpmlib, GLIBC filtered):
>     /bin/sh
>     config(golang-github-haproxytech-dataplaneapi)
>     haproxy
>     libc.so.6()(64bit)
>     libpthread.so.0()(64bit)
>     rtld(GNU_HASH)
>     systemd
> 
> golang-github-haproxytech-dataplaneapi-devel (rpmlib, GLIBC filtered):
>     go-filesystem
>     golang(github.com/GehirnInc/crypt)
>     golang(github.com/GehirnInc/crypt/md5_crypt)
>     golang(github.com/GehirnInc/crypt/sha256_crypt)
>     golang(github.com/GehirnInc/crypt/sha512_crypt)
>     golang(github.com/docker/go-units)
>     golang(github.com/go-openapi/errors)
>     golang(github.com/go-openapi/loads)
>     golang(github.com/go-openapi/runtime)
>     golang(github.com/go-openapi/runtime/flagext)
>     golang(github.com/go-openapi/runtime/middleware)
>     golang(github.com/go-openapi/runtime/security)
>     golang(github.com/go-openapi/spec)
>     golang(github.com/go-openapi/strfmt)
>     golang(github.com/go-openapi/swag)
>     golang(github.com/go-openapi/validate)
>     golang(github.com/haproxytech/client-native)
>     golang(github.com/haproxytech/client-native/configuration)
>     golang(github.com/haproxytech/client-native/runtime)
>     golang(github.com/haproxytech/config-parser)
>     golang(github.com/haproxytech/config-parser/types)
>     golang(github.com/haproxytech/models)
>     golang(github.com/jessevdk/go-flags)
>     golang(github.com/rs/cors)
>     golang(github.com/shirou/gopsutil/host)
>     golang(github.com/shirou/gopsutil/mem)
>     golang(github.com/sirupsen/logrus)
>     golang(golang.org/x/net/netutil)
>     golang(golang.org/x/sys/unix)
> 
> golang-github-haproxytech-dataplaneapi-debuginfo (rpmlib, GLIBC filtered):
> 
> golang-github-haproxytech-dataplaneapi-debugsource (rpmlib, GLIBC filtered):
> 
> 
> 
> Provides
> --------
> golang-github-haproxytech-dataplaneapi:
>     config(golang-github-haproxytech-dataplaneapi)
>     golang-github-haproxytech-dataplaneapi
>     golang-github-haproxytech-dataplaneapi(x86-64)
> 
> golang-github-haproxytech-dataplaneapi-devel:
>     golang(github.com/haproxytech/dataplaneapi)
>     golang(github.com/haproxytech/dataplaneapi/adapters)
>     golang(github.com/haproxytech/dataplaneapi/handlers)
>     golang(github.com/haproxytech/dataplaneapi/haproxy)
>     golang(github.com/haproxytech/dataplaneapi/misc)
>     golang(github.com/haproxytech/dataplaneapi/operations)
>     golang(github.com/haproxytech/dataplaneapi/operations/acl)
>     golang(github.com/haproxytech/dataplaneapi/operations/backend)
>     golang(github.com/haproxytech/dataplaneapi/operations/backend_switching_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/bind)
>     golang(github.com/haproxytech/dataplaneapi/operations/configuration)
>     golang(github.com/haproxytech/dataplaneapi/operations/defaults)
>     golang(github.com/haproxytech/dataplaneapi/operations/discovery)
>     golang(github.com/haproxytech/dataplaneapi/operations/filter)
>     golang(github.com/haproxytech/dataplaneapi/operations/frontend)
>     golang(github.com/haproxytech/dataplaneapi/operations/global)
>     golang(github.com/haproxytech/dataplaneapi/operations/http_request_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/http_response_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/information)
>     golang(github.com/haproxytech/dataplaneapi/operations/log_target)
>     golang(github.com/haproxytech/dataplaneapi/operations/reloads)
>     golang(github.com/haproxytech/dataplaneapi/operations/server)
>     golang(github.com/haproxytech/dataplaneapi/operations/server_switching_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/sites)
>     golang(github.com/haproxytech/dataplaneapi/operations/specification)
>     golang(github.com/haproxytech/dataplaneapi/operations/stats)
>     golang(github.com/haproxytech/dataplaneapi/operations/stick_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/tcp_request_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/tcp_response_rule)
>     golang(github.com/haproxytech/dataplaneapi/operations/transactions)
>     golang-github-haproxytech-dataplaneapi-devel
>     golang-ipath(github.com/haproxytech/dataplaneapi)
> 
> golang-github-haproxytech-dataplaneapi-debuginfo:
>     debuginfo(build-id)
>     golang-github-haproxytech-dataplaneapi-debuginfo
>     golang-github-haproxytech-dataplaneapi-debuginfo(x86-64)
> 
> golang-github-haproxytech-dataplaneapi-debugsource:
>     golang-github-haproxytech-dataplaneapi-debugsource
>     golang-github-haproxytech-dataplaneapi-debugsource(x86-64)
> 
> 
> 
> Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16
> Command line :/usr/bin/fedora-review -b 1773720 -L ~/git/haproxytech/RPMS -v
> Buildroot used: fedora-rawhide-x86_64
> Active plugins: Generic, Shell-api
> Disabled plugins: C/C++, Java, Perl, Ocaml, Python, Haskell, SugarActivity, PHP, fonts, R
> Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
> 
> Built with local dependencies:
>     ~/git/haproxytech/RPMS/golang-github-gehirninc-crypt-devel-0-0.2.20200214git6c0105a.fc31.noarch.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-client-native-devel-1.2.6-2.fc31.noarch.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-config-parser-devel-1.2.0-1.fc31.noarch.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-1.2.4-5.fc31.x86_64.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debuginfo-1.2.4-5.fc31.x86_64.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-debugsource-1.2.4-5.fc31.x86_64.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-dataplaneapi-devel-1.2.4-5.fc31.noarch.rpm
>     ~/git/haproxytech/RPMS/golang-github-haproxytech-models-devel-1.2.4-2.fc31.noarch.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux