[Bug 1773716] Review Request: golang-github-gehirninc-crypt - Pure Go crypt(3) Implementation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1773716



--- Comment #10 from Brandon Perkins <bperkins@xxxxxxxxxx> ---
(In reply to Brandon Perkins from comment #7)
> (In reply to Ryan O'Hara from comment #5)
> > Rpmlint
> > -------
> > Checking:
> > golang-github-gehirninc-crypt-devel-0-0.1.20191113git6c0105a.fc32.noarch.rpm
> >           golang-github-gehirninc-crypt-0-0.1.20191113git6c0105a.fc32.src.rpm
> > golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir
> > /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath
> > golang-github-gehirninc-crypt.src: W: no-%build-section
> > 2 packages and 0 specfiles checked; 0 errors, 2 warnings.
> > 
> > 
> > - No issues. First, there should not be a %build section for a -devel go
> > package. Second, I believe that .goipath are unavoidable with go packages.
> 
> Both statements are correct.
> 

> > golang-github-gehirninc-crypt-devel.noarch: W: hidden-file-or-dir
> > /usr/share/gocode/src/github.com/GehirnInc/crypt/.goipath
> > 1 packages and 0 specfiles checked; 0 errors, 2 warnings.
> > 
> > - Same as above. I believe these .goipath files are unavoidable.
> > 

I've at least learned a lot more about rpmlint.  This may be a feature request
for rpmlint, but basically, the problem is that we're missing a filter in
/usr/share/rpmlint/config.  I figured it out by looking at the line:

addFilter(r"hidden-file-or-dir .*/man5/\.k5login\.5[^/]+$")

so, by adding an equivalent line:

addFilter(r"hidden-file-or-dir
/usr/share/gocode/src/github\.com/.*/.*/.goipath$")

for .goipath, we can get a clean rpmlint:

$ sudo mkdir -p /var/lib/mock/fedora-rawhide-x86_64/root/root/.config
$ echo "addFilter(r\"hidden-file-or-dir
/usr/share/gocode/src/github\.com/.*/.*/.goipath$\")" > /tmp/rpmlint.config
$ sudo cp /tmp/rpmlint.config
/var/lib/mock/fedora-rawhide-x86_64/root/root/.config/rpmlint
$ LANG=C.utf8 mock -q -r fedora-rawhide-x86_64 --no-bootstrap-chroot
--no-cleanup-after --no-clean --enable-network --chroot -- rpmlint -f
/root/.config/rpmlint golang-github-gehirninc-crypt-devel
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux