https://bugzilla.redhat.com/show_bug.cgi?id=1809908 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jamatos@xxxxxxxx Flags| |fedora-review+ --- Comment #2 from José Matos <jamatos@xxxxxxxx> --- This is what fedora-review has to say about it: - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/lib64/R/library/profvis/htmlwidgets/lib/d3/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files As discussed in other reviews some issues are not true and other are moot. My main issue is with the bundle js packages but they are clearly labelled as such and can be changed later if the scenario changes. The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
