[Bug 1804529] Review Request: pam-cryptsetup - PAM module for updating LUKS-encrypted volumes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1804529



--- Comment #3 from Michel Alexandre Salim <michel@xxxxxxxxxxxxxxx> ---
SPEC URL: https://salimma.fedorapeople.org/specs/admin/pam-cryptsetup.spec
SRPM URL:
https://salimma.fedorapeople.org/specs/admin/pam-cryptsetup-0.1-0.2.20190823.7b42892.fc30.src.rpm
So parenthesizing an expression no longer suppresses a warning (my diff sort of
worked because I also subtracted by 1 in two call sites; not sure why on Fedora
30/31 the first strcpy did not trigger a warning).

Since -Wall is part of the Fedora default compiler flags I don't want to touch
it, but I've reworked the patch to now use #pragma for the entire block where
helper.c does strcpy and then verify the null terminator is in place.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux