Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: xorg-x11-drv-radeonhd - driver for AMD GPG r5xx/r6xx Chipsets https://bugzilla.redhat.com/show_bug.cgi?id=331571 ------- Additional Comments From rhbugs@xxxxxxxxxxxxxxxx 2007-10-15 10:59 EST ------- Thanks for the review. I'll address all your points here: * Removed driverdir definition. * Any timezone is arbitrary. I chose to use the canonical timezone instead of "the one the current packager happens to reside in". Is that wrong? * Why Version: 1.1.1? Because the upstream package says so. I am going to take that upstream. My guess is this will change to 0.0.1. * Buildroot definition: http://fedoraproject.org/wiki/Packaging/Guidelines#head-b4fdd45fa76cbf54c885ef0836361319ab962473 I quote: "If unsure, simply pick [the one with mktemp]." That looks to me like "officially accepted". * Description shortened. * %files now without -n * Removed .fc8 from %changelog entries. * "ExcludeArch: s390 s390x" was copied from xorg-x11-drv-ati, so I guessed it made sense. I think I'll keep it. The new 0.5.20071015git package addresses these things: http://radeonhd.lauft.net/xorg-x11-drv-radeonhd/xorg-x11-drv-radeonhd.spec http://radeonhd.lauft.net/xorg-x11-drv-radeonhd/xorg-x11-drv-radeonhd-1.1.1-0.5.20071015git.fc8.src.rpm I will upload a 0.6 when I have talked with upstream about Version: 1.1.1 vs. 0.0.1. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review