[Bug 1808552] Review Request: python-numpoly - Numpoly is a generic library for creating, manipulating and evaluating arrays of polynomials.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1808552



--- Comment #2 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> ---
Just been looking at this.

Luis, the tool uses `pyproject.toml`, so you'll have to use different macros to
build it correctly. Take a look at this:
https://src.fedoraproject.org/rpms/pyproject-rpm-macros

Other things I noticed:

- the License field is wrong, should just be "BSD".
- tests aren't run, please enable them,
- there are a few other rpmlint errors, please run rpmlint on the spec/srpm and
correct those.

I'll do a full review once you've updated the spec to use the pyproject macros.

Cheers,
Ankur

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux