https://bugzilla.redhat.com/show_bug.cgi?id=1808276 Artem <ego.cordatus@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |POST Summary|Review request: |Review request: |libuInputPlus - a c++ |libuInputPlus - C++ wrapper |wrapper around libuinput |around libuinput Flags|fedora-review? |fedora-review+ --- Comment #6 from Artem <ego.cordatus@xxxxxxxxx> --- LGTM. Few minor issues may be corrected during import: 1. W: no-dependency-on libuInputPlus/libuInputPlus-libs/liblibuInputPlus W: tag-in-description C Requires: Put 'Requires: %{name}%{?_isa} = %{version}-%{release}' before %description tag 2. W: summary-not-capitalized C development files for libuInputPlus Summary: development files for %{name} -> Summary: Development files for %{name} As for converting package name in lower case not sure. I asked other maintainers and they said best option is ask upstream about this. It's up on you. I leave quote here from packaging guidelines: > Package names SHOULD be in lower case and use dashes in preference to underscores. You can take some cues from the name of the upstream tarball, the project name from which this software came, and the name which has been used for this package by other distributions/packagers in the past. You can also request guidance from the upstream developers. Do not just blindly follow those examples, however, as package names SHOULD strive to be consistent within Fedora more than consistent between distributions. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
