https://bugzilla.redhat.com/show_bug.cgi?id=1808571 Susi Lehtola <susi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |susi.lehtola@xxxxxx --- Comment #7 from Susi Lehtola <susi.lehtola@xxxxxx> --- (In reply to Antonio T. (sagitter) from comment #6) > (In reply to Miro Hrončok from comment #5) > > Regarding: > > > > pathfix.py -pn -i "%{__python3}" > > %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py > > pathfix.py -pn -i "%{__python3}" > > %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py > > pathfix.py -pn -i "%{__python3}" > > %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py > > pathfix.py -pn -i "%{__python3}" > > %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py > > > > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccframe.py > > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccget.py > > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/ccwrite.py > > chmod a+x %{buildroot}%{python3_sitelib}/cclib/scripts/cda.py > > > > Wouldn't it be better to drop the shebangs entirely? Or are the users of > > this package expected to execute those files directly? > > Shebangs were already there in the form `#!/usr/bin/env python` But they can be removed altogether since these files are in the Python library directory. The shebangs only matter in the case where the user would run these directly i.e. run $ /usr/lib64/python3.7/site-packages/cclib/scripts/ccget.py The files are not in the PATH so the shebangs can be dropped. Also, since this is an unretirement procedure, please rebase your spec using the old one and see that you inherit all of its fixes to various issues. Usually one also keeps the old changelog. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
