https://bugzilla.redhat.com/show_bug.cgi?id=1808276 --- Comment #4 from Artem <ego.cordatus@xxxxxxxxx> --- LGTM, just few minor nitpicks, mostly cosmetic, but some items as MUST: 1. - Static libraries in -static or -devel subpackage, providing -devel if present. Note: Package has .a files: libuInputPlus-devel. Does not provide -static: libuInputPlus-devel. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Just remove it in %install stage: rm -f %{buildroot}%{_libdir}/libuInputPlus.a 2. Move pkgconfig files into -devel package: %files devel %{_libdir}/pkgconfig/* 3. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_listing_shared_library_files %{_libdir}/libuInputPlus.so.0 %{_libdir}/libuInputPlus.so.%{version} -> %{_libdir}/libuInputPlus.so.0* 4. The rule of thumb is always use popd with pushd. Also you can skip them in %install stage: pushd %{_target_platform} %make_install -> %make_install -C %{_target_platform} 5. W: summary-not-capitalized C development files for libuInputPlus Summary: a c++ wrapper around libuinput -> Summary: C++ wrapper around libuinput Even if this is not documented yet in guidelines, many packagers recommends to skip A/The in Summary. It's OK to use them in %description. 6. Add to devel package Requires: %{name}%{?_isa} = %{version}-%{release} https://docs.fedoraproject.org/en-US/packaging-guidelines/#_requiring_base_package 7. W: incoherent-version-in-changelog 0.1.4-1.fc31 ['0.1.4-1.fc33', '0.1.4-1'] In %changelog: 0.1.4-1.fc31 -> 0.1.4-1 --- The one this which i am not sure is - should we convert package name to lower case or not: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_general_naming I'll ask about this other maintainers... --- Also just note: next time when you post here new, updated spec and SRPM you can just post plain links for them without additional 'FAS Username: foo'. Hope this saves you some time. :) -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
