https://bugzilla.redhat.com/show_bug.cgi?id=1795053 --- Comment #2 from Fabian Affolter <mail@xxxxxxxxxxxxxxxxxx> --- (In reply to dan.cermak from comment #1) > Overall this looks good, I have the following questions/comments: > > - please don't put plain macros into comments, that's just asking for > trouble with m4, prevent their expansion via %% or replace the # with %dnl > (will only work in Rawhide & F32 though) Doc building is no longer excluded. > - upstream has a test suite, consider running it in %check? They have but it's required to run a server as the calls are not mocked. I'm not aware that the build system is able to run containers. > - you have added 3 sed calls into %prep: > * please add an explanation why you have added these and what they do > * You unrestrict the pycurl dependency: given that you don't run any > tests, this seems a bit dangerous, especially given this oddly specific > version requirement (and that we have a newer version in Rawhide). If you > believe that the dependency specification is wrong, then please submit a > patch upstream and patch the sources in the spec. Strict release pinning breaks the installations. There is an issue with 7.43.0.3. Fedora 31 ships 7.43.0.2 and Fedora 32 7.43.0.5. With both versions of pycurl I'm not able to reproduce the reported issues. Thus I removed the pinning. > - The documentation is not built, why? If there is an upstream issue, please > link to it. This issue seems to be resolved now. Update files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/wfuzz.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/wfuzz-2.4.5-2.fc31.src.rpm -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
