[Bug 1797368] Review Request: perl-String-Interpolate-Named - Interpolate named variables in text strings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=1797368

Petr Pisar <ppisar@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Flags|fedora-review?              |fedora-review+



--- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> ---
Source and Url addresses are usable. Ok.
Source archive (SHA-256:
727299fa69258b604770e059ec4da906bfde71861fdd1e3e89e30677371c5a80) is original.
Ok.
Summary verified from README. Ok.
Description verified from README. Ok.
License verified from lib/String/Interpolate/Named.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require 'perl(Exporter)' (lib/String/Interpolate/Named.pm:10).

All tests pass. Ok.

$ rpmlint perl-String-Interpolate-Named.spec
../SRPMS/perl-String-Interpolate-Named-1.00-3.fc33.src.rpm
../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p
../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Feb 28 10:50
/usr/share/doc/perl-String-Interpolate-Named
-rw-r--r--    1 root     root                      780 Oct 31 13:33
/usr/share/doc/perl-String-Interpolate-Named/Changes
-rw-r--r--    1 root     root                     1154 Oct 31 13:53
/usr/share/doc/perl-String-Interpolate-Named/README
-rw-r--r--    1 root     root                     3573 Feb 28 10:50
/usr/share/man/man3/String::Interpolate::Named.3pm.gz
drwxr-xr-x    2 root     root                        0 Feb 28 10:50
/usr/share/perl5/vendor_perl/String
drwxr-xr-x    2 root     root                        0 Feb 28 10:50
/usr/share/perl5/vendor_perl/String/Interpolate
-rw-r--r--    1 root     root                     8687 Oct 31 13:56
/usr/share/perl5/vendor_perl/String/Interpolate/Named.pm
File layout and the permissions are Ok.

$ rpm -q --requires -p
../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm | sort -f |
uniq -c
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(parent)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p
../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm | sort -f |
uniq -c
      1 perl(String::Interpolate::Named) = 1.00
      1 perl-String-Interpolate-Named = 1.00-3.fc33
Binary provides are Ok.

$ resolvedeps rawhide
../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F33
(https://koji.fedoraproject.org/koji/taskinfo?taskID=41981404). Ok.

Otherwise the package is in line with Fedora and Perl packaging guide lines.

Please correct the 'FIX' item before building this package.
Resolution: Package APPROVED.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
You are always notified about changes to this product and component
_______________________________________________
package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx
To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx




[Index of Archives]     [Fedora Users]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite Conditions]     [KDE Users]

  Powered by Linux