Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: ltsp-ltspswapd - Daemon that uses nbd to provide swap space for LTSP thin clients https://bugzilla.redhat.com/show_bug.cgi?id=331531 pertusus@xxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pertusus@xxxxxxx ------- Additional Comments From pertusus@xxxxxxx 2007-10-15 05:39 EST ------- The version/release of the package isn't right, have a look at http://fedoraproject.org/wiki/Packaging/NamingGuidelines#head-cfd71146dbb6f00cec9fe3623ea619f843394837 Regarding the name, why not simply ltspswapd? For the source url, it is almost right, but please have a look at http://fedoraproject.org/wiki/Packaging/SourceURL for an even better style. I don't think that %{_localstatedir}/opt/ is the right var directory for the swap files. Maybe %{_localstatedir}/lib/ or %{_localstatedir}/spool (with appropriate subdirectories), but /opt in general should always be left empty by rpm installations. You should use the -p switch to install, to keep timestamps, like install -p -m 0644 %{SOURCE1} ${RPM_BUILD_ROOT}/%{_sysconfdir}/sysconfig/ltspswapd The Source3 file is a bit strange. Isn't it a remnant of something else? Suggestion: the %{_*dir} marcos already have a leading /, so it is not needed in ${RPM_BUILD_ROOT}/%{_sysconfdir}/sysconfig/, or in /%{_sysconfdir}/sysconfig/ltspswapd -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review