Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: paktype-fonts - Fonts for Arabic from PakType https://bugzilla.redhat.com/show_bug.cgi?id=318191 panemade@xxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ ------- Additional Comments From panemade@xxxxxxxxx 2007-10-15 05:23 EST ------- Review: + package builds in mock (development i386). + rpmlint is silent for SRPM but NOT for RPM. paktype-fonts.noarch: W: file-not-utf8 /usr/share/doc/paktype-fonts-2.0/PakTypeNaqsh-readme.txt This can be ignored as iconv is failing to convert this document. + source files match upstream url cd75bd7fa714f307d25407a61f8bc43c paktype-20061222.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + fonts scriptlets present. + no duplicates in %files. + file permissions are appropriate. + Not a GUI App. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review