https://bugzilla.redhat.com/show_bug.cgi?id=1807409 José Matos <jamatos@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jamatos@xxxxxxxx Assignee|nobody@xxxxxxxxxxxxxxxxx |jamatos@xxxxxxxx Flags| |fedora-review+ --- Comment #2 from José Matos <jamatos@xxxxxxxx> --- The package is simple. :-) The complaints of fedora-review are: - Package have the default element marked as %%doc :DESCRIPTION - Package requires R-core. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ The first is bogus. The second makes sense on the paper but since this is binary package it already requires R-core. The third one and taking example of the rstudio review https://bugzilla.redhat.com/show_bug.cgi?id=1803528 according to the link above it should be listed explicitly. I have asked in the package mailing list for a clarification but meanwhile it does not hurt to include it directly. The package is approved. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
