Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: system-config-services https://bugzilla.redhat.com/show_bug.cgi?id=226470 ------- Additional Comments From nphilipp@xxxxxxxxxx 2007-10-15 04:45 EST ------- (In reply to comment #1) > Preliminary Review:- > > rpmlint on SRPM and RPM gave me > ------------------------------------- > system-config-services.src:26: W: unversioned-explicit-obsoletes serviceconf > system-config-services.src:27: W: unversioned-explicit-obsoletes > redhat-config-services added versions > system-config-services.src:168: W: macro-in-%changelog _bindir quoted macro ("%%{_bindir}") > system-config-services.src: W: summary-not-capitalized system-config-services is > an initscript and xinetd configuration utility > system-config-services.src: E: description-line-too-long system-config-services > is a utility which allows you to configure which services fixing this now would break specspo translations -> we'll have to postpone that until after F8 is out > system-config-services.src: W: invalid-license GPL changed license tag to GPLv2+ > system-config-services.noarch: W: file-not-utf8 > /usr/share/doc/system-config-services-0.9.10/html/legalnotice.html recoded documentation to UTF-8 > system-config-services.noarch: E: script-without-shebang > /usr/share/system-config-services/servicemethods.py > system-config-services.noarch: E: script-without-shebang > /usr/share/system-config-services/checklist.py installed files with correct permissions > system-config-services.noarch: W: summary-not-capitalized system-config-services > is an initscript and xinetd configuration utility > system-config-services.noarch: E: description-line-too-long > system-config-services is a utility which allows you to configure which services idem > system-config-services.noarch: W: incoherent-version-in-changelog 0.9.10 > 0.9.10-1.fc8 added release to changelog versions > system-config-services.noarch: W: invalid-license GPL > system-config-services.noarch: W: obsolete-not-provided serviceconf > system-config-services.noarch: W: obsolete-not-provided redhat-config-services idem > system-config-services.noarch: W: conffile-without-noreplace-flag > /etc/pam.d/serviceconf > system-config-services.noarch: W: conffile-without-noreplace-flag > /etc/pam.d/system-config-services > system-config-services.noarch: W: conffile-without-noreplace-flag > /etc/security/console.apps/serviceconf > system-config-services.noarch: W: conffile-without-noreplace-flag > /etc/security/console.apps/system-config-services used %config(noreplace) > also, > 1) packaging guidelines suggests use of make as > http://fedoraproject.org/wiki/Packaging/Guidelines#head-525c7d76890cb22df33b759c65c35c82bf434d2e used "make %{?_smp_mflags}" > 2) good to use %defattr(-,root,root,-) used "%defattr(-,root,root,-)" > Update package. Better to provide new SPEC and SRPM links for this package > before actually committing in CVS. merge review... (In reply to comment #2) > Using xdg-open would be better than htmlview: fixed system-config-services-0.9.13-1.fc8 is building right now with these changes -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review