https://bugzilla.redhat.com/show_bug.cgi?id=1797364 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ |requires_doc_text? | --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> --- TODO: There is still %{__perl} in 'Requires: perl(:MODULE_COMPAT_'. Use plain "perl". TODO: I recommend you to sort the BuildRequires lexicographically. It will make upgrading the package later easier. TODO: To suppress these warnings: Warning: the following files are missing in your kit: hb_src/harfbuzz/check-c-linkage-decls.sh [...] inc/Devel/CheckLib.pm Please inform the author. you can remove the file entries from MANIFEST file. E.g. this command in %prep section will do it: perl -i -ne 'print $_ unless m{^(hb_src|inc)/}' MANIFEST All tests pass. Ok. $ rpmlint perl-HarfBuzz-Shaper.spec ../SRPMS/perl-HarfBuzz-Shaper-0.018.4-2.fc33.src.rpm ../RPMS/x86_64/perl-HarfBuzz-Shaper-* sh: /usr/bin/python2: No such file or directory 4 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-HarfBuzz-Shaper-0.018.4-2.fc33.x86_64.rpm | sort -f | uniq -c 1 harfbuzz 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.4)(64bit) 1 libharfbuzz.so.0()(64bit) 1 libperl.so.5.30()(64bit) 1 libpthread.so.0()(64bit) 1 perl(:MODULE_COMPAT_5.30.1) 1 perl(:VERSION) >= 5.10.1 1 perl(Carp) 1 perl(Encode) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 1 rtld(GNU_HASH) FIX: Do not run-require 'harfbuzz' at all. The dependency comes automatically via 'libharfbuzz.so.0()(64bit)'. It's redundant. $ resolvedeps rawhide ../RPMS/x86_64/perl-HarfBuzz-Shaper-0.018.4-2.fc33.x86_64.rpm Binary dependencies are resolvable. Ok. Please correct the 'FIX' item and consider fixing the 'TODO' items before building this package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. You are always notified about changes to this product and component _______________________________________________ package-review mailing list -- package-review@xxxxxxxxxxxxxxxxxxxxxxx To unsubscribe send an email to package-review-leave@xxxxxxxxxxxxxxxxxxxxxxx Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedoraproject.org/archives/list/package-review@xxxxxxxxxxxxxxxxxxxxxxx
